linux-kernel - Re: [PATCH 0/3] media: wave5: Fix critical issues in driver remove path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <519cdc6933469378086e97d11d31552d76ddd9d6.camel@ndufresne.ca>
Date: Wed, 03 Dec 2025 13:10:58 -0500
From: Nicolas Dufresne <nicolas@...fresne.ca>
To: Xulin Sun <xulin.sun@...driver.com>, nas.chung@...psnmedia.com, 
	jackson.lee@...psnmedia.com, mchehab@...nel.org
Cc: linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3] media: wave5: Fix critical issues in driver remove
 path

Hi,


Le mercredi 03 décembre 2025 à 12:09 +0800, Xulin Sun a écrit :
> This patch series fixes three critical issues in the wave5 VPU driver's
> remove path that cause kernel warnings and system crashes.
> 
> The issues were discovered and consistently reproduced on kernel 6.12.58-rt6
> with the TI AM62A platform. While testing on kernel 6.18 shows the issues
> are harder to trigger, the underlying logic problems still exist in the code.
> 
> Patch 1: Fixes PM runtime reference count underflow
> Patch 2: Fixes kthread worker destruction warning  
> Patch 3: Fixes kernel panic due to incorrect cleanup order

Thanks, applicable to all your patches, please reformat your commits message to
follow the guidelines. Avoid the "Symptoms:/Root cause:/Fix:" titles, reader can
figure-out what this is. And then reverse the order, what is fixed in the first
paragraph, explanation of the root cause in the second and what users would get
(symptoms) at the end.

Also for all your patches, add the missing Fixes: tags, these are important for
backports.

> 
> All patches have been tested with 50+ consecutive encoding operations and
> multiple modprobe/rmmod cycles without any warnings or crashes on 6.12.58-rt6.

I don't think its going to be a big deal, but please, retest on media-
committers/next (currently 6.18-rc5) branch and report.

With all this covered, you can add my Rb to your v2.

Reviewed-by: Nicolas Dufresne <nicolas.dufresne@...labora.com>

regards,
Nicolas

> 
> Xulin Sun (3):
>   media: wave5: Fix PM runtime usage count underflow
>   media: wave5: Fix kthread worker destruction in polling mode
>   media: wave5: Fix device cleanup order to prevent kernel panic
> 
>  drivers/media/platform/chips-media/wave5/wave5-vpu.c | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)