linux-kernel - RE: [PATCH v3 2/2] clk: visconti: Add VIIF clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: 
 <TYYPR01MB1225694BE61A6CB7A74B44EF5C3D9A@TYYPR01MB12256.jpnprd01.prod.outlook.com>
Date: Wed, 3 Dec 2025 07:50:24 +0000
From: <yuji.ishikawa.x51@...l.toshiba>
To: <sboyd@...nel.org>, <conor+dt@...nel.org>, <krzk+dt@...nel.org>,
        <mturquette@...libre.com>, <nobuhiro.iwamatsu.x90@...l.toshiba>,
        <p.zabel@...gutronix.de>, <robh@...nel.org>
CC: <linux-clk@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>
Subject: RE: [PATCH v3 2/2] clk: visconti: Add VIIF clocks

> -----Original Message-----
> From: Stephen Boyd <sboyd@...nel.org>
> Sent: Friday, November 21, 2025 11:57 AM
> To: Conor Dooley <conor+dt@...nel.org>; Krzysztof Kozlowski
> <krzk+dt@...nel.org>; Michael Turquette <mturquette@...libre.com>;
> iwamatsu nobuhiro(岩松 信洋 □ＤＩＴＣ○ＣＰＴ)
> <nobuhiro.iwamatsu.x90@...l.toshiba>; Philipp Zabel
> <p.zabel@...gutronix.de>; Rob Herring <robh@...nel.org>; ishikawa yuji(石
> 川 悠司 □ＡＩＤＣ○ＥＡ開) <yuji2.ishikawa@...hiba.co.jp>
> Cc: linux-clk@...r.kernel.org; linux-arm-kernel@...ts.infradead.org;
> linux-kernel@...r.kernel.org; devicetree@...r.kernel.org; ishikawa yuji(石川
> 悠司 □ＡＩＤＣ○ＥＡ開) <yuji2.ishikawa@...hiba.co.jp>
> Subject: Re: [PATCH v3 2/2] clk: visconti: Add VIIF clocks
> 
> Quoting Yuji Ishikawa (2025-11-13 23:05:12)
> > Add the control sequence of register bits to handle the clocks and the
> > resets of Video Input Interface.
> >
> > Signed-off-by: Yuji Ishikawa <yuji2.ishikawa@...hiba.co.jp>
> > ---
> 
> Applied to clk-next but see below.
> 
> > diff --git a/drivers/clk/visconti/clkc-tmpv770x.c
> > b/drivers/clk/visconti/clkc-tmpv770x.c
> > index 94a736da6..1e2e8d643 100644
> > --- a/drivers/clk/visconti/clkc-tmpv770x.c
> > +++ b/drivers/clk/visconti/clkc-tmpv770x.c
> > @@ -18,8 +18,8 @@
> >  #include "reset.h"
> >
> >  /* Must be equal to the last clock/reset ID increased by one */
> > -#define CLKS_NR        (TMPV770X_CLK_BUSLCK + 1)
> > -#define RESETS_NR      (TMPV770X_RESET_SBUSCLK + 1)
> > +#define CLKS_NR        (TMPV770X_CLK_VIIFBS1_PROC + 1)
> > +#define RESETS_NR      (TMPV770X_RESET_VIIFBS1_L1ISP + 1)
> >
> >  static DEFINE_SPINLOCK(tmpv770x_clk_lock);
> >  static DEFINE_SPINLOCK(tmpv770x_rst_lock);
> > @@ -32,6 +32,10 @@ static const struct clk_parent_data
> pietherplls_parent_data[] = {
> >         { .fw_name = "pietherpll", .name = "pietherpll", },  };
> >
> > +static const struct clk_parent_data pidnnplls_parent_data[] = {
> > +       { .fw_name = "pidnnpll", .name = "pidnnpll", }, };
> 
> This is wrong. There's no "pidnnpll" in the DT binding for
> toshiba,tmpv770x-pismu 'clocks' property. Please send a follow up patch that
> cleans up the usage of clk_parent_data in this driver.

Thank you for pointing this out. I'll check the driver and consider how to clean up the usage.

Regards,
Yuji Ishikawa