linux-kernel - Re: [PATCH v1] fs: PM: Fix reverse check in filesystems_freeze

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <biwoc3mkrh3ynxl5wftj7caasxf2rkjwhb23vmbqaxeus4iuwu@g6kjgdsfsgvk>
Date: Wed, 3 Dec 2025 11:28:03 +0100
From: Jan Kara <jack@...e.cz>
To: "Rafael J. Wysocki" <rafael@...nel.org>
Cc: Christian Brauner <brauner@...nel.org>, 
	Alexander Viro <viro@...iv.linux.org.uk>, Jan Kara <jack@...e.cz>, 
	Ard Biesheuvel <ard.biesheuvel@...aro.org>, linux-fsdevel@...r.kernel.org, 
	LKML <linux-kernel@...r.kernel.org>, Linux PM <linux-pm@...r.kernel.org>
Subject: Re: [PATCH v1] fs: PM: Fix reverse check in
 filesystems_freeze_callback()

On Tue 02-12-25 19:27:29, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> 
> The freeze_all_ptr check in filesystems_freeze_callback() introduced by
> commit a3f8f8662771 ("power: always freeze efivarfs") is reverse which
> quite confusingly causes all file systems to be frozen when
> filesystem_freeze_enabled is false.
> 
> On my systems it causes the WARN_ON_ONCE() in __set_task_frozen() to
> trigger, most likely due to an attempt to freeze a file system that is
> not ready for that.
> 
> Add a logical negation to the check in question to reverse it as
> appropriate.
> 
> Fixes: a3f8f8662771 ("power: always freeze efivarfs")
> Cc: 6.18+ <stable@...r.kernel.org> # 6.18+
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  fs/super.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/fs/super.c
> +++ b/fs/super.c
> @@ -1188,7 +1188,7 @@ static void filesystems_freeze_callback(
>  	if (!sb->s_op->freeze_fs && !sb->s_op->freeze_super)
>  		return;
>  
> -	if (freeze_all_ptr && !(sb->s_type->fs_flags & FS_POWER_FREEZE))
> +	if (!freeze_all_ptr && !(sb->s_type->fs_flags & FS_POWER_FREEZE))
>  		return;
>  
>  	if (!get_active_super(sb))
> 
> 
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR