linux-kernel - Re: [PATCH v2 1/2] remoteproc: qcom_q6v5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <62911215-1211-4cd7-ac9f-232e3f585249@oss.qualcomm.com>
Date: Wed, 3 Dec 2025 12:24:22 +0100
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Alexandru Gagniuc <mr.nuke.me@...il.com>, andersson@...nel.org,
        mathieu.poirier@...aro.org, linux-arm-msm@...r.kernel.org,
        linux-remoteproc@...r.kernel.org, p.zabel@...gutronix.de,
        Govind Singh <govinds@...eaurora.org>,
        Gokul Sriram Palanisamy <quic_gokulsri@...cinc.com>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] remoteproc: qcom_q6v5_wcss: fix parsing of
 qcom,halt-regs

On 12/2/25 5:26 PM, Alexandru Gagniuc wrote:
> The "qcom,halt-regs" consists of a phandle reference followed by the
> three offsets within syscon for halt registers. Thus, we need to
> request 4 integers from of_property_read_variable_u32_array(), with
> the halt_reg ofsets at indexes 1, 2, and 3. Offset 0 is the phandle.
> 
> With MAX_HALT_REG at 3, of_property_read_variable_u32_array() returns
> -EOVERFLOW, causing .probe() to fail.
> 
> Increase MAX_HALT_REG to 4, and update the indexes accordingly.
> 
> Fixes: 0af65b9b915e ("remoteproc: qcom: wcss: Add non pas wcss Q6 support for QCS404")
> 
> Signed-off-by: Alexandru Gagniuc <mr.nuke.me@...il.com>
> ---

Hm, that surely could have never worked

Reviewed-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>

Konrad