linux-kernel - Re: [PATCH v2 2/2] remoteproc: qcom_q6v5_wcss: drop redundant wcss_q6_bcr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c743b023-21ac-4e59-97d3-982c1467c8cc@oss.qualcomm.com>
Date: Wed, 3 Dec 2025 13:09:38 +0100
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Alexandru Gagniuc <mr.nuke.me@...il.com>, andersson@...nel.org,
        mathieu.poirier@...aro.org, linux-arm-msm@...r.kernel.org,
        linux-remoteproc@...r.kernel.org, p.zabel@...gutronix.de,
        Gokul Sriram Palanisamy <quic_gokulsri@...cinc.com>,
        Govind Singh <govinds@...eaurora.org>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] remoteproc: qcom_q6v5_wcss: drop redundant
 wcss_q6_bcr_reset

On 12/2/25 5:26 PM, Alexandru Gagniuc wrote:
> The wcss_q6_bcr_reset used on QCS404, and wcss_q6_reset used on IPQ
> are the same. "BCR reset" is redundant, and likely a mistake. Use the
> documented "wcss_q6_reset" instead. Drop ".wcss_q6_reset_required"
> from the descriptor, since all targets now need it.
> 
> Fixes: 0af65b9b915e ("remoteproc: qcom: wcss: Add non pas wcss Q6 support for QCS404")
> 
> Signed-off-by: Alexandru Gagniuc <mr.nuke.me@...il.com>
> ---

[...]

> -	wcss->wcss_q6_bcr_reset = devm_reset_control_get_exclusive(dev, "wcss_q6_bcr_reset");
> -	if (IS_ERR(wcss->wcss_q6_bcr_reset)) {
> -		dev_err(wcss->dev, "unable to acquire wcss_q6_bcr_reset\n");
> -		return PTR_ERR(wcss->wcss_q6_bcr_reset);
> +	wcss->wcss_q6_reset = devm_reset_control_get_exclusive(dev, "wcss_q6_reset");
> +	if (IS_ERR(wcss->wcss_q6_reset)) {

This changes the bindings expectations

*however*

it actually fixes the driver to consume the intended ones (qcom,q6v5.txt)
(not even yaml!!!) which houses the description of the qcs404 wcss lists
wcss_q6_reset and *not* "wcss_q6_bcr_reset"

Please add a paragraph mentioning this in the commit message and add my

Reviewed-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>

Konrad