linux-kernel - Re: [PATCH] LoongArch: Use __pmd() helper for __swp_entry_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAhV-H5tpiaCD6DM1V6AZRFYpprk9RuUNOVadcHOxbOWPc0WHw@mail.gmail.com>
Date: Wed, 3 Dec 2025 21:52:55 +0800
From: Huacai Chen <chenhuacai@...nel.org>
To: WangYuli <wangyuli@...c.io>
Cc: kernel@...0n.name, akpm@...ux-foundation.org, david@...nel.org, 
	willy@...radead.org, bjorn@...osinc.com, agordeev@...ux.ibm.com, 
	zhangtianyang@...ngson.cn, apopple@...dia.com, thuth@...hat.com, 
	linmag7@...il.com, loongarch@...ts.linux.dev, linux-kernel@...r.kernel.org, 
	WangYuli <wangyl5933@...naunicom.cn>
Subject: Re: [PATCH] LoongArch: Use __pmd() helper for __swp_entry_to_pmd()

On Wed, Dec 3, 2025 at 6:05 PM WangYuli <wangyuli@...c.io> wrote:
>
> Hi Huacai,
>
> On 2025/12/3 17:46, Huacai Chen wrote:
> >> diff --git a/arch/loongarch/include/asm/pgtable.h b/arch/loongarch/include/asm/pgtable.h
> >> index 03fb60432fde..4e09f7e8bbec 100644
> >> --- a/arch/loongarch/include/asm/pgtable.h
> >> +++ b/arch/loongarch/include/asm/pgtable.h
> >> @@ -299,7 +299,7 @@ static inline pte_t mk_swap_pte(unsigned long type, unsigned long offset)
> >>   #define __pte_to_swp_entry(pte) ((swp_entry_t) { pte_val(pte) })
> >>   #define __swp_entry_to_pte(x)  ((pte_t) { (x).val })
> > Why not change __swp_entry_to_pte() together with __pte()?
> >
> > Huacai
>
> I haven't investigated this closely, but it's odd that changing just
> this one spot was enough to get it to compile — there doesn't seem to be
> an error at __swp_entry_to_pte.
>
> But you're right that changing both together looks neater.
>
> If you think it's necessary, I'm happy to submit a patch v2.
Yes, please!

Huacai
>
> Thanks,
>
> --
>
> WangYuli
>