linux-kernel - Re: [PATCH] HID: Intel-thc-hid: Intel-thc: fix dma_unmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aTBtQpJI_eu00H9N@smile.fi.intel.com>
Date: Wed, 3 Dec 2025 19:02:58 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Thomas Fourier <fourier.thomas@...il.com>
Cc: Even Xu <even.xu@...el.com>, Xinpeng Sun <xinpeng.sun@...el.com>,
	Jiri Kosina <jikos@...nel.org>,
	Benjamin Tissoires <bentiss@...nel.org>,
	Mark Pearson <mpearson-lenovo@...ebb.ca>,
	Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: Intel-thc-hid: Intel-thc: fix dma_unmap_sg() nents
 value

On Wed, Dec 03, 2025 at 05:56:35PM +0100, Thomas Fourier wrote:
> The `dma_unmap_sg()` functions should be called with the same nents as the
> `dma_map_sg()`, not the value the map function returned.
> 
> Save the number of entries in struct thc_dma_configuration.

Your email has an empty To:. Some spamfilters may be triggered by this.
I recommend to use `b4` tool to handle the patches.

The change LGTM,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

-- 
With Best Regards,
Andy Shevchenko