linux-kernel - Re: [PATCH v6.19-rc1 1/1] perf auxtrace: Include sys/types.h for pid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP-5=fXgypbv6qdDV8nZXZySgebhAHXH1a1J7A8Wv91ko-+Qxw@mail.gmail.com>
Date: Wed, 3 Dec 2025 09:28:56 -0800
From: Ian Rogers <irogers@...gle.com>
To: Arnaldo Carvalho de Melo <acme@...nel.org>
Cc: Namhyung Kim <namhyung@...nel.org>, Adrian Hunter <adrian.hunter@...el.com>, 
	James Clark <james.clark@...aro.org>, Jiri Olsa <jolsa@...nel.org>, 
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, linux-perf-users@...r.kernel.org
Subject: Re: [PATCH v6.19-rc1 1/1] perf auxtrace: Include sys/types.h for pid_t

On Wed, Dec 3, 2025 at 6:50 AM Arnaldo Carvalho de Melo <acme@...nel.org> wrote:
>
> In 754187ad73b73bcb ("perf build: Remove NO_AUXTRACE build option")
> sys/types.h was removed, which broke the build in all Alpine Linux
> releases, as musl libc has pid_t defined via sys/types.h, add it back.
>
> Fixes: 754187ad73b73bcb ("perf build: Remove NO_AUXTRACE build option")
> Cc: Adrian Hunter <adrian.hunter@...el.com>
> Cc: Ian Rogers <irogers@...gle.com>
> Cc: James Clark <james.clark@...aro.org>
> Cc: Jiri Olsa <jolsa@...nel.org>
> Cc: Namhyung Kim <namhyung@...nel.org>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>

Reviewed-by: Ian Rogers <irogers@...gle.com>

Thanks,
Ian

> ---
>  tools/perf/util/auxtrace.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/util/auxtrace.h b/tools/perf/util/auxtrace.h
> index eee2c11f76668348..6947f3f284c02928 100644
> --- a/tools/perf/util/auxtrace.h
> +++ b/tools/perf/util/auxtrace.h
> @@ -7,6 +7,7 @@
>  #ifndef __PERF_AUXTRACE_H
>  #define __PERF_AUXTRACE_H
>
> +#include <sys/types.h>
>  #include <stdio.h> // FILE
>  #include <linux/perf_event.h>
>  #include <linux/types.h>
> --
> 2.52.0
>