linux-kernel - Re: [PATCH v2] i2c: designware: Replace magic numbers with named constants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOPX747Y9Dbzdn2PfSU3wqce5iFx_XfJJa+Zoq30iEsgJCRdPQ@mail.gmail.com>
Date: Thu, 4 Dec 2025 15:07:55 +0300
From: Artem Shimko <a.shimko.dev@...il.com>
To: Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc: andi.shyti@...nel.org, andriy.shevchenko@...ux.intel.com, jsd@...ihalf.com, 
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] i2c: designware: Replace magic numbers with named constants

Hi Mika,

Sorry about that, I'm a newbie and might make mistakes.

Yes, I'm confused about the versions myself, and yes, there is a v3.

Am I right? Even though I already sent it in response to the kernel
robot report, would it be better to forward v3 to a separate thread?

Regards,
Artem

On Thu, Dec 4, 2025 at 3:00 PM Mika Westerberg
<mika.westerberg@...ux.intel.com> wrote:
>
> On Thu, Dec 04, 2025 at 02:41:29PM +0300, Artem Shimko wrote:
> > Replace various magic numbers with properly named constants to improve
> > code readability and maintainability. This includes constants for
> > register access, timing adjustments, timeouts, FIFO parameters,
> > and default values.
> >
> > The change makes the code more self-documenting without altering any
> > functionality.
> >
> > Signed-off-by: Artem Shimko <a.shimko.dev@...il.com>
> > ---
> >
> > Hello maintainers and reviewers,
> >
> > Fix replaces magic numbers throughout the DesignWare I2C driver with named
> > constants to improve code readability and maintainability.
> >
> > The change introduces constants for register access, timing adjustments,
> > timeouts, FIFO parameters, and default values, all properly documented
> > with comments.
> >
> > No functional changes.
>
> There is already v3 at least of this patch. What changed?
>
> Also can you please send new versions on a new thread instead of replying
> on the existing one? It is really hard to follow.