linux-kernel - Re: [PATCH v2 2/2] iio: adc: ad9467: add support for ad9211

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aTF7qbjbtYqZCR95@smile.fi.intel.com>
Date: Thu, 4 Dec 2025 14:16:41 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Tomas Melin <tomas.melin@...sala.com>
Cc: Lars-Peter Clausen <lars@...afoo.de>,
	Michael Hennerich <Michael.Hennerich@...log.com>,
	Nuno Sa <nuno.sa@...log.com>, Jonathan Cameron <jic23@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-iio@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] iio: adc: ad9467: add support for ad9211

On Thu, Dec 04, 2025 at 02:14:49PM +0200, Andy Shevchenko wrote:
> On Thu, Dec 04, 2025 at 08:01:04AM +0000, Tomas Melin wrote:
> > The AD9211 is a 10-bit monolithic sampling analog-to-digital
> > converter optimized for high performance, low power, and ease

Also just noticed that this paragraph is visible shorter than the last one,
can you make them approximately the same line length?

> > of use. The product operates at up to a 300 MSPS conversion

Is it megasamples? Then MSps?

> > rate and is optimized for outstanding dynamic performance
> > in wideband carrier and broadband systems.

> > The scale table implemented here is not an exact match with the
> > datasheet as the table presented there is missing some information.
> > The reference presents these values as being linear,
> > but that does not add up. There is information missing in the table.
> > Implemented scale table matches values at the middle and at the ends,
> > smoothing the curve towards middle and end.
> > Impact on end result from deviation in scale factor affects only software
> > using it for scaling. All the possible hw-settings are also available with
> > this implementation.
> 
> 
> Some amendment in the headers would be nice to have,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...el.com>

...

> + array_size.h
> 
> >  #include <linux/delay.h>
> >  #include <linux/gpio/consumer.h>
> >  #include <linux/of.h>
> > +#include <linux/units.h>
> >  
> 
> You can drop one blank line here.

-- 
With Best Regards,
Andy Shevchenko