linux-kernel - RE: [PATCH] EDAC/amd64: avoid -Wformat-security warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CY8PR11MB71348CB80E76A94FB00AB17989A6A@CY8PR11MB7134.namprd11.prod.outlook.com>
Date: Thu, 4 Dec 2025 12:19:57 +0000
From: "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>
To: Arnd Bergmann <arnd@...nel.org>, Yazen Ghannam <yazen.ghannam@....com>,
	Borislav Petkov <bp@...en8.de>, "Luck, Tony" <tony.luck@...el.com>, "Avadhut
 Naik" <avadhut.naik@....com>
CC: Arnd Bergmann <arnd@...db.de>, Ingo Molnar <mingo@...nel.org>, "Thorsten
 Blum" <thorsten.blum@...ux.dev>, Mario Limonciello
	<mario.limonciello@....com>, "linux-edac@...r.kernel.org"
	<linux-edac@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] EDAC/amd64: avoid -Wformat-security warning

> From: Arnd Bergmann <arnd@...nel.org>
> Sent: Thursday, December 4, 2025 6:02 PM
> To: Yazen Ghannam <yazen.ghannam@....com>; Borislav Petkov
> <bp@...en8.de>; Luck, Tony <tony.luck@...el.com>; Avadhut Naik
> <avadhut.naik@....com>
> Cc: Arnd Bergmann <arnd@...db.de>; Ingo Molnar <mingo@...nel.org>;
> Zhuo, Qiuxu <qiuxu.zhuo@...el.com>; Thorsten Blum
> <thorsten.blum@...ux.dev>; Mario Limonciello
> <mario.limonciello@....com>; linux-edac@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Subject: [PATCH] EDAC/amd64: avoid -Wformat-security warning
> 
> From: Arnd Bergmann <arnd@...db.de>
> 
> Using a variable as a format string causes a (default-disabled) warning:
> 
> drivers/edac/amd64_edac.c: In function 'per_family_init':
> drivers/edac/amd64_edac.c:3914:17: error: format not a string literal and no
> format arguments [-Werror=format-security]
>  3914 |                 scnprintf(pvt->ctl_name, sizeof(pvt->ctl_name), tmp_name);
>       |                 ^~~~~~~~~
> 
> The code here is safe, but in order to enable the warning by default in the
> future, change this instance to pass the name indirectly.
> 
> Fixes: e9abd990aefd ("EDAC/amd64: Generate ctl_name string at runtime")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---

LGTM. Thanks!

  Reviewed-by: Qiuxu Zhuo <qiuxu.zhuo@...el.com>

[...]