linux-kernel - Re: [PATCH] EDAC/amd64: avoid -Wformat-security warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <17d7baeb-4864-4894-aa92-978af300fce4@amd.com>
Date: Thu, 4 Dec 2025 09:51:24 -0600
From: "Naik, Avadhut" <avadnaik@....com>
To: Arnd Bergmann <arnd@...nel.org>, Yazen Ghannam <yazen.ghannam@....com>,
 Borislav Petkov <bp@...en8.de>, Tony Luck <tony.luck@...el.com>,
 Avadhut Naik <avadhut.naik@....com>
Cc: Arnd Bergmann <arnd@...db.de>, Ingo Molnar <mingo@...nel.org>,
 Qiuxu Zhuo <qiuxu.zhuo@...el.com>, Thorsten Blum <thorsten.blum@...ux.dev>,
 Mario Limonciello <mario.limonciello@....com>, linux-edac@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] EDAC/amd64: avoid -Wformat-security warning



On 12/4/2025 04:02, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Using a variable as a format string causes a (default-disabled) warning:
> 
> drivers/edac/amd64_edac.c: In function 'per_family_init':
> drivers/edac/amd64_edac.c:3914:17: error: format not a string literal and no format arguments [-Werror=format-security]
>  3914 |                 scnprintf(pvt->ctl_name, sizeof(pvt->ctl_name), tmp_name);
>       |                 ^~~~~~~~~
> 
> The code here is safe, but in order to enable the warning by default in
> the future, change this instance to pass the name indirectly.
> 
> Fixes: e9abd990aefd ("EDAC/amd64: Generate ctl_name string at runtime")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/edac/amd64_edac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
> index 2391f3469961..63fca0ee2c23 100644
> --- a/drivers/edac/amd64_edac.c
> +++ b/drivers/edac/amd64_edac.c
> @@ -3911,7 +3911,7 @@ static int per_family_init(struct amd64_pvt *pvt)
>  	}
>  
>  	if (tmp_name)
> -		scnprintf(pvt->ctl_name, sizeof(pvt->ctl_name), tmp_name);
> +		scnprintf(pvt->ctl_name, sizeof(pvt->ctl_name), "%s", tmp_name);
>  	else
>  		scnprintf(pvt->ctl_name, sizeof(pvt->ctl_name), "F%02Xh_M%02Xh",
>  			  pvt->fam, pvt->model);


Thanks for fixing this!

	Reviewed-by: Avadhut Naik <avadhut.naik@....com>

-- 
Thanks,
Avadhut Naik