[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAKYAXd_-ctfkz1E_Sqh0bJMarUE8rDrd2o7yKKa_cOFGPaYELg@mail.gmail.com>
Date: Fri, 5 Dec 2025 09:35:38 +0900
From: Namjae Jeon <linkinjeon@...nel.org>
To: chenxiaosong.chenxiaosong@...ux.dev
Cc: sfrench@...ba.org, smfrench@...il.com, linkinjeon@...ba.org,
linux-cifs@...r.kernel.org, linux-kernel@...r.kernel.org,
chenxiaosong@...nxiaosong.com, ChenXiaoSong <chenxiaosong@...inos.cn>
Subject: Re: [PATCH 09/10] smb: create common/common.h and common/common.c
On Thu, Dec 4, 2025 at 2:00 PM <chenxiaosong.chenxiaosong@...ux.dev> wrote:
>
> From: ChenXiaoSong <chenxiaosong@...inos.cn>
>
> Preparation for moving client/smb2maperror.c to common/.
>
> We can put cifs_md4 and smb2maperror into a single smb_common.ko,
> instead of creating two separate .ko (cifs_md4.ko and smb2maperror.ko).
Sorry, I prefer not to create new *.ko for only smb2maperror.
>
> - rename md4.h -> common.h, and update include guard
> - create common.c, and move module info from cifs_md4.c into common.c
ksmbd does not use md4 in smb/common, I don't prefer this either.
I would appreciate it if you could send me the patch set again except these.
>
> Signed-off-by: ChenXiaoSong <chenxiaosong@...inos.cn>
Powered by blists - more mailing lists