linux-kernel - Re: [PATCH 09/10] smb: create common/common.h and common/common.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5f7758db-cf88-4335-9a03-72be1f7d6b65@linux.dev>
Date: Fri, 5 Dec 2025 08:58:52 +0800
From: ChenXiaoSong <chenxiaosong.chenxiaosong@...ux.dev>
To: Namjae Jeon <linkinjeon@...nel.org>
Cc: sfrench@...ba.org, smfrench@...il.com, linkinjeon@...ba.org,
 linux-cifs@...r.kernel.org, linux-kernel@...r.kernel.org,
 chenxiaosong@...nxiaosong.com, ChenXiaoSong <chenxiaosong@...inos.cn>
Subject: Re: [PATCH 09/10] smb: create common/common.h and common/common.c

OK, I will create new smb2maperror.ko and will send v2 soon.

Thanks for your review and suggestions.

Thanks,
ChenXiaoSong.

On 12/5/25 08:35, Namjae Jeon wrote:
> On Thu, Dec 4, 2025 at 2:00 PM <chenxiaosong.chenxiaosong@...ux.dev> wrote:
>>
>> From: ChenXiaoSong <chenxiaosong@...inos.cn>
>>
>> Preparation for moving client/smb2maperror.c to common/.
>>
>> We can put cifs_md4 and smb2maperror into a single smb_common.ko,
>> instead of creating two separate .ko (cifs_md4.ko and smb2maperror.ko).
> Sorry, I prefer not to create new *.ko for only smb2maperror.
>>
>>    - rename md4.h -> common.h, and update include guard
>>    - create common.c, and move module info from cifs_md4.c into common.c
> ksmbd does not use md4 in smb/common, I don't prefer this either.
> I would appreciate it if you could send me the patch set again except these.
>>
>> Signed-off-by: ChenXiaoSong <chenxiaosong@...inos.cn>