linux-kernel - Re: [PATCH v2] fs: exfat: improve error code handling in exfat_find_empty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3f846d9a-72b7-49bf-922e-b75938ddbf8b@samsung.com>
Date: Fri, 5 Dec 2025 15:05:36 +0900
From: Sungjong Seo <sj1557.seo@...sung.com>
To: Haotian Zhang <vulab@...as.ac.cn>, linkinjeon@...nel.org,
	yuezhang.mo@...y.com
Cc: linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] fs: exfat: improve error code handling in
 exfat_find_empty_entry()



On 25. 12. 5. 10:59, Haotian Zhang wrote:
> Change the type of 'ret' from unsigned int to int in
> exfat_find_empty_entry(). Although the implicit type conversion
> (int -> unsigned int -> int) does not cause actual bugs in
> practice, using int directly is more appropriate for storing
> error codes returned by exfat_alloc_cluster().
> 
> This improves code clarity and consistency with standard error
> handling practices.
> 
> Signed-off-by: Haotian Zhang <vulab@...as.ac.cn>
> ---
>  fs/exfat/namei.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/exfat/namei.c b/fs/exfat/namei.c
> index f5f1c4e8a29f..f2a87ecd79f9 100644
> --- a/fs/exfat/namei.c
> +++ b/fs/exfat/namei.c
> @@ -304,8 +304,8 @@ static int exfat_find_empty_entry(struct inode *inode,
>  		struct exfat_chain *p_dir, int num_entries,
>  		struct exfat_entry_set_cache *es)
>  {
> -	int dentry;
> -	unsigned int ret, last_clu;
> +	int dentry, ret;
> +	unsigned int last_clu;

The patch looks good to me:

Reviewed-by: Sungjong Seo <sj1557.seo@...sung.com>

>  	loff_t size = 0;
>  	struct exfat_chain clu;
>  	struct super_block *sb = inode->i_sb;