linux-kernel - Re: [PATCH] net: ti: icssg-prueth: add PTP_1588_CLOCK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ea427664-d7a9-4bf8-86e7-47dc8fc84ba4@linux.dev>
Date: Fri, 5 Dec 2025 00:12:30 +0000
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Arnd Bergmann <arnd@...nel.org>, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Richard Cochran <richardcochran@...il.com>,
 MD Danish Anwar <danishanwar@...com>, Diogo Ivo <diogo.ivo@...mens.com>,
 Jan Kiszka <jan.kiszka@...mens.com>, Roger Quadros <rogerq@...com>,
 Basharath Hussain Khaja <basharath@...thit.com>, "Andrew F. Davis"
 <afd@...com>, Parvathi Pudi <parvathi@...thit.com>
Cc: Arnd Bergmann <arnd@...db.de>, Meghana Malladi <m-malladi@...com>,
 Sascha Hauer <s.hauer@...gutronix.de>,
 Mohan Reddy Putluru <pmohan@...thit.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: ti: icssg-prueth: add PTP_1588_CLOCK_OPTIONAL
 dependency

On 04/12/2025 10:01, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The new icssg-prueth driver needs the same dependency as the other parts
> that use the ptp-1588:
> 
> WARNING: unmet direct dependencies detected for TI_ICSS_IEP
>    Depends on [m]: NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_TI [=y] && PTP_1588_CLOCK_OPTIONAL [=m] && TI_PRUSS [=y]
>    Selected by [y]:
>    - TI_PRUETH [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_TI [=y] && PRU_REMOTEPROC [=y] && NET_SWITCHDEV [=y]
> 
> Add the correct dependency on the two drivers missing it, and remove
> the pointless 'imply' in the process.
> 
> Fixes: e654b85a693e ("net: ti: icssg-prueth: Add ICSSG Ethernet driver for AM65x SR1.0 platforms")
> Fixes: 511f6c1ae093 ("net: ti: icssm-prueth: Adds ICSSM Ethernet driver")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>   drivers/net/ethernet/ti/Kconfig | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig
> index a54d71155263..fe5b2926d8ab 100644
> --- a/drivers/net/ethernet/ti/Kconfig
> +++ b/drivers/net/ethernet/ti/Kconfig
> @@ -209,6 +209,7 @@ config TI_ICSSG_PRUETH_SR1
>   	depends on PRU_REMOTEPROC
>   	depends on NET_SWITCHDEV
>   	depends on ARCH_K3 && OF && TI_K3_UDMA_GLUE_LAYER
> +	depends on PTP_1588_CLOCK_OPTIONAL
>   	help
>   	  Support dual Gigabit Ethernet ports over the ICSSG PRU Subsystem.
>   	  This subsystem is available on the AM65 SR1.0 platform.
> @@ -234,7 +235,7 @@ config TI_PRUETH
>   	depends on PRU_REMOTEPROC
>   	depends on NET_SWITCHDEV
>   	select TI_ICSS_IEP
> -	imply PTP_1588_CLOCK
> +	depends on PTP_1588_CLOCK_OPTIONAL
>   	help
>   	  Some TI SoCs has Programmable Realtime Unit (PRU) cores which can
>   	  support Single or Dual Ethernet ports with the help of firmware code

Reviewed-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>