linux-kernel - Re: [PATCH v7 00/22] wifi: nxpwifi: create nxpwifi to support iw61x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aTKT6RcWecQh1/CL@nxpwireless-Inspiron-14-Plus-7440>
Date: Fri, 5 Dec 2025 16:12:25 +0800
From: Jeff Chen <jeff.chen_1@....com>
To: Jeff Johnson <jeff.johnson@....qualcomm.com>
Cc: linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
	briannorris@...omium.org, johannes@...solutions.net,
	francesco@...cini.it, tsung-hsien.hsieh@....com,
	s.hauer@...gutronix.de
Subject: Re: [PATCH v7 00/22] wifi: nxpwifi: create nxpwifi to support iw61x

On Mon, Nov 17, 2025 at 11:10:24 AM -0800, Jeff Johnson wrote:
> So that this series would have an additional set of eyes I ran this through
> the automation I use for ath.git.
> 
> It reports multiple instances of using the now obsolete networking multi-line
> comment style.
> Starting from the first patch:
> +/* Fills HT capability information field, AMPDU Parameters field, HT extended
> +/* This function returns the pointer to an entry in BA Stream
> +/* This function handles the command response of delete a block
> ...
> 
> Current guidance is to use the standard multi-line comment style
> /*
>  * first line of comment
>  * [more lines of comment]
>  * last line of commnt
>  */
> 
> It also flagged one incorrect use of kernel-doc comment style:
> +       /** rate for LG pkt, RATE flag will be present, it shows datarate in
> 
> There are also numerous spelling issues reported by checkpatch.pl --codespell
> TYPO_SPELLING: 'interation' may be misspelled - perhaps 'iteration'?
> TYPO_SPELLING: 'Dimentions' may be misspelled - perhaps 'Dimensions'?
> TYPO_SPELLING: 'interfacces' may be misspelled - perhaps 'interfaces'?
> TYPO_SPELLING: 'formate' may be misspelled - perhaps 'format'?
> TYPO_SPELLING: 'verion' may be misspelled - perhaps 'version'?
> TYPO_SPELLING: 'Timstamp' may be misspelled - perhaps 'Timestamp'?
> TYPO_SPELLING: 'intializes' may be misspelled - perhaps 'initializes'?
> TYPO_SPELLING: 'statistc' may be misspelled - perhaps 'statistic'?

Hi Jeff,

Thanks for running the series through your automation and sharing the feedback.
I’ve addressed these points in nxpwifi v8.

> Also "wifi: nxpwifi: add initial SDIO bus driver support" reports
> UNDOCUMENTED_DT_STRING: DT compatible string "nxp,iw61x" appears un-documented
> -- check ./Documentation/devicetree/bindings/
> 
> Is there an associated DT patch out there?
> 
> The MAINTAINERS patch reports multiple instances of:
> MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:

In nxpwifi v8, I added the Device Tree binding for "nxp,iw61x". However, I received
some negative feedback on that patch, mainly about the description focusing on the
driver instead of the hardware and missing proper CC and subject prefix. I’ll address
these issues in the next revision.

> So suggest you use all options to checkpatch.pl on your series
> 
> /jeff
>