linux-kernel - Re: [PATCH next] drm/xe/xe_sriov_vfio: Fix return value in xe_sriov_vfio_migration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e963b9a5-77db-4f3a-b172-a5e9a66d937d@intel.com>
Date: Fri, 5 Dec 2025 13:05:16 +0100
From: Michal Wajdeczko <michal.wajdeczko@...el.com>
To: Dan Carpenter <dan.carpenter@...aro.org>,
	Michał Winiarski <michal.winiarski@...el.com>
CC: Lucas De Marchi <lucas.demarchi@...el.com>,
	Thomas Hellström <thomas.hellstrom@...ux.intel.com>,
	"Rodrigo Vivi" <rodrigo.vivi@...el.com>, David Airlie <airlied@...il.com>,
	"Simona Vetter" <simona@...ll.ch>, <intel-xe@...ts.freedesktop.org>,
	<dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>,
	<kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH next] drm/xe/xe_sriov_vfio: Fix return value in
 xe_sriov_vfio_migration_supported()



On 12/5/2025 12:39 PM, Dan Carpenter wrote:
> The xe_sriov_vfio_migration_supported() function is type bool so
> returning -EPERM means returning true.  Return false instead.
> 
> Fixes: 17f22465c5a5 ("drm/xe/pf: Export helpers for VFIO")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Reviewed-by: Michal Wajdeczko <michal.wajdeczko@...el.com>

> ---
>  drivers/gpu/drm/xe/xe_sriov_vfio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_sriov_vfio.c b/drivers/gpu/drm/xe/xe_sriov_vfio.c
> index e9a7615bb5c5..3da81af97b8b 100644
> --- a/drivers/gpu/drm/xe/xe_sriov_vfio.c
> +++ b/drivers/gpu/drm/xe/xe_sriov_vfio.c
> @@ -21,7 +21,7 @@ EXPORT_SYMBOL_FOR_MODULES(xe_sriov_vfio_get_pf, "xe-vfio-pci");
>  bool xe_sriov_vfio_migration_supported(struct xe_device *xe)
>  {
>  	if (!IS_SRIOV_PF(xe))
> -		return -EPERM;
> +		return false;
>  
>  	return xe_sriov_pf_migration_supported(xe);
>  }