linux-kernel - Re: [PATCH v3 1/2] cpufreq: Return -EOPNOTSUPP if no policy is boost supported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bad4857d-ba90-4587-b36f-6999fc66a898@hisilicon.com>
Date: Fri, 5 Dec 2025 09:50:02 +0800
From: Jie Zhan <zhanjie9@...ilicon.com>
To: Lifeng Zheng <zhenglifeng1@...wei.com>, <rafael@...nel.org>,
	<viresh.kumar@...aro.org>
CC: <linux-pm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linuxarm@...wei.com>, <jonathan.cameron@...wei.com>, <lihuisong@...wei.com>,
	<yubowen8@...wei.com>, <zhangpengjie2@...wei.com>, <wangzhi12@...wei.com>,
	<linhongye@...artners.com>
Subject: Re: [PATCH v3 1/2] cpufreq: Return -EOPNOTSUPP if no policy is boost
 supported


On 12/2/2025 3:27 PM, Lifeng Zheng wrote:
> In cpufreq_boost_trigger_state(), if all the policies are boost
> unsupported, policy_set_boost() will not be called and this function will
> return 0. But it is better to return an error to indicate that the platform
> doesn't support boost.
> 
> Signed-off-by: Lifeng Zheng <zhenglifeng1@...wei.com>
> Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
LGTM.  Thanks!

Reviewed-by: Jie Zhan <zhanjie9@...ilicon.com>
> ---
>  drivers/cpufreq/cpufreq.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index e8d7544b77b8..a4399e5490da 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -2806,7 +2806,7 @@ static int cpufreq_boost_trigger_state(int state)
>  {
>  	struct cpufreq_policy *policy;
>  	unsigned long flags;
> -	int ret = 0;
> +	int ret = -EOPNOTSUPP;
>  
>  	/*
>  	 * Don't compare 'cpufreq_driver->boost_enabled' with 'state' here to
> @@ -2826,6 +2826,10 @@ static int cpufreq_boost_trigger_state(int state)
>  		if (ret)
>  			goto err_reset_state;
>  	}
> +
> +	if (ret)
> +		goto err_reset_state;
> +
>  	cpus_read_unlock();
>  
>  	return 0;