linux-kernel - Re: [PATCH v3 2/2] cpufreq: cpufreq_boost_trigger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <744b0c91-4164-4532-a4f3-3496141fd869@hisilicon.com>
Date: Fri, 5 Dec 2025 09:50:42 +0800
From: Jie Zhan <zhanjie9@...ilicon.com>
To: Lifeng Zheng <zhenglifeng1@...wei.com>, <rafael@...nel.org>,
	<viresh.kumar@...aro.org>
CC: <linux-pm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linuxarm@...wei.com>, <jonathan.cameron@...wei.com>, <lihuisong@...wei.com>,
	<yubowen8@...wei.com>, <zhangpengjie2@...wei.com>, <wangzhi12@...wei.com>,
	<linhongye@...artners.com>
Subject: Re: [PATCH v3 2/2] cpufreq: cpufreq_boost_trigger_state()
 optimization



On 12/2/2025 3:27 PM, Lifeng Zheng wrote:
> Optimize the error handling branch code in cpufreq_boost_trigger_state().
> 
> Signed-off-by: Lifeng Zheng <zhenglifeng1@...wei.com>
> Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
LGTM.  Thanks!

Reviewed-by: Jie Zhan <zhanjie9@...ilicon.com>
> ---
>  drivers/cpufreq/cpufreq.c | 13 ++++---------
>  1 file changed, 4 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index a4399e5490da..a2507a5b42d9 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -2823,19 +2823,14 @@ static int cpufreq_boost_trigger_state(int state)
>  			continue;
>  
>  		ret = policy_set_boost(policy, state);
> -		if (ret)
> -			goto err_reset_state;
> +		if (unlikely(ret))
> +			break;
>  	}
>  
> -	if (ret)
> -		goto err_reset_state;
> -
>  	cpus_read_unlock();
>  
> -	return 0;
> -
> -err_reset_state:
> -	cpus_read_unlock();
> +	if (likely(!ret))
> +		return 0;
>  
>  	write_lock_irqsave(&cpufreq_driver_lock, flags);
>  	cpufreq_driver->boost_enabled = !state;