linux-kernel - [PATCH v1] mtd: sm_ftl: use strscpy() in sm_attr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20251206035313.10190-1-dharanitharan725@gmail.com>
Date: Sat,  6 Dec 2025 03:53:13 +0000
From: Dharanitharan R <dharanitharan725@...il.com>
To: Miquel Raynal <miquel.raynal@...tlin.com>,
	Richard Weinberger <richard@....at>,
	Vignesh Raghavendra <vigneshr@...com>
Cc: linux-mtd@...ts.infradead.org,
	linux-kernel@...r.kernel.org,
	Dharanitharan R <dharanitharan725@...il.com>
Subject: [PATCH v1] mtd: sm_ftl: use strscpy() in sm_attr_show()

In sm_ftl.c, the sm_attr_show() function currently copies
attribute data using:

    strncpy(buf, sm_attr->data, sm_attr->len);
    return sm_attr->len;

Using strncpy() can be unsafe because it does not guarantee
a NUL terminator if the source length equals the buffer size.
Although sm_attr->data comes from internal structures and
is NUL-terminated, it is cleaner and safer to use strscpy(),
which guarantees NUL termination and avoids zero-padding.

The destination buffer is PAGE_SIZE bytes, which is sufficient
to hold sm_attr->data without truncation. The return value
of strscpy() matches the expected behavior of sm_attr_show().

Replace the strncpy() call with:

    return strscpy(buf, sm_attr->data, PAGE_SIZE);

Signed-off-by: Dharanitharan R <dharanitharan725@...il.com>
---
 drivers/mtd/sm_ftl.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/mtd/sm_ftl.c b/drivers/mtd/sm_ftl.c
index abc7b186353f..229fdc4a754a 100644
--- a/drivers/mtd/sm_ftl.c
+++ b/drivers/mtd/sm_ftl.c
@@ -44,8 +44,7 @@ static ssize_t sm_attr_show(struct device *dev, struct device_attribute *attr,
 	struct sm_sysfs_attribute *sm_attr =
 		container_of(attr, struct sm_sysfs_attribute, dev_attr);

-	strncpy(buf, sm_attr->data, sm_attr->len);
-	return sm_attr->len;
+	return strscpy(buf, sm_attr->data, PAGE_SIZE);
 }

-- 
2.43.0