linux-kernel - Re: [PATCH v4 1/6] PCI: starfive: Use regulator APIs instead of GPIO APIs to enable the 3V3 power supply of PCIe slots

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f9cc4a7e-c71a-439f-9e71-8cba4986ceb7@suse.com>
Date: Sat, 6 Dec 2025 13:37:58 +0100
From: Matthias Brugger <mbrugger@...e.com>
To: Conor Dooley <conor@...nel.org>, Hal Feng <hal.feng@...rfivetech.com>
Cc: Conor Dooley <conor+dt@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Palmer Dabbelt
 <palmer@...belt.com>, Paul Walmsley <pjw@...nel.org>,
 Albert Ou <aou@...s.berkeley.edu>, "Rafael J . Wysocki" <rafael@...nel.org>,
 Viresh Kumar <viresh.kumar@...aro.org>,
 Lorenzo Pieralisi <lpieralisi@...nel.org>,
 Krzysztof Wilczyński <kwilczynski@...nel.org>,
 Manivannan Sadhasivam <mani@...nel.org>, Bjorn Helgaas
 <bhelgaas@...gle.com>, Liam Girdwood <lgirdwood@...il.com>,
 Mark Brown <broonie@...nel.org>,
 Emil Renner Berthing <emil.renner.berthing@...onical.com>,
 Heinrich Schuchardt <heinrich.schuchardt@...onical.com>,
 E Shattow <e@...eshell.de>, devicetree@...r.kernel.org,
 linux-pci@...r.kernel.org, linux-riscv@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/6] PCI: starfive: Use regulator APIs instead of GPIO
 APIs to enable the 3V3 power supply of PCIe slots

On 25/11/25 21:00, Conor Dooley wrote:
> On Tue, Nov 25, 2025 at 03:55:59PM +0800, Hal Feng wrote:
>> The "enable-gpio" property is not documented in the dt-bindings and
>> using GPIO APIs is not a standard method to enable or disable PCIe
>> slot power, so use regulator APIs to replace them.
>>
>> Tested-by: Matthias Brugger <mbrugger@...e.com>
> 
> Is this actually a valid tag?
> He provided one for the series on v3, which didn't include this patch.
> 

No it is not. As I only tested v3. But I was able to test v4 as well, so 
for the whole series:

Tested-by: Matthias Brugger <mbrugger@...e.com>

Regards,
Matthias