linux-kernel - Re: [PATCH v6 1/2] dt-bindings: iio: adc: Add TI ADS1018/ADS1118

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251206193324.1d0e6fef@jic23-huawei>
Date: Sat, 6 Dec 2025 19:33:24 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Kurt Borja <kuurtb@...il.com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Tobias Sperling
 <tobias.sperling@...ting.com>, David Lechner <dlechner@...libre.com>, Nuno
 Sá <nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>,
 linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Jonathan Cameron
 <Jonathan.Cameron@...wei.com>, Krzysztof Kozlowski
 <krzysztof.kozlowski@....qualcomm.com>
Subject: Re: [PATCH v6 1/2] dt-bindings: iio: adc: Add TI ADS1018/ADS1118

On Thu, 04 Dec 2025 13:01:27 -0500
Kurt Borja <kuurtb@...il.com> wrote:

> Add documentation for Texas Instruments ADS1018 and ADS1118
> analog-to-digital converters.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>
> Signed-off-by: Kurt Borja <kuurtb@...il.com>
A couple of trivial things that aren't worth a respin.

Thanks,

Jonathan

> ---
>  .../devicetree/bindings/iio/adc/ti,ads1018.yaml    | 82 ++++++++++++++++++++++
>  MAINTAINERS                                        |  6 ++
>  2 files changed, 88 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads1018.yaml b/Documentation/devicetree/bindings/iio/adc/ti,ads1018.yaml
> new file mode 100644
> index 000000000000..93c9b2921a54
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/ti,ads1018.yaml
> @@ -0,0 +1,82 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/adc/ti,ads1018.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TI ADS1018/ADS1118 SPI analog to digital converter
> +
> +maintainers:
> +  - Kurt Borja <kuurtb@...il.com>
> +
> +description: |
> +  The ADS1018/ADS1118 is a precision, low-power, 12-bit or 16-bit, noise-free,
If you spin again: 12-bit/16-bit
to align with ADS1018/ADS1118 earlier in the line.
Otherwise it sounds like each can do either mode.

I'd also drop the noise-free.  To me that seems overly optimistic marketing and
it doesn't add anything useful.


> +  analog-to-digital converter (ADC). It integrates a programmable gain amplifier
> +  (PGA), voltage reference, oscillator and high-accuracy temperature sensor.
> +
> +  Datasheets:
> +    - ADS1018: https://www.ti.com/lit/ds/symlink/ads1018.pdf
> +    - ADS1118: https://www.ti.com/lit/ds/symlink/ads1118.pdf
> +
> +properties:
> +  compatible:
> +    enum:
> +      - ti,ads1018
> +      - ti,ads1118
> +
> +  reg:
> +    maxItems: 1
> +
> +  vdd-supply: true
> +
> +  spi-max-frequency:
> +    maximum: 4000000
> +
> +  spi-cpha: true
> +
> +  interrupts:
> +    description: DOUT/DRDY (Data Out/Data Ready) line.
> +    maxItems: 1
> +
> +  drdy-gpios:
> +    description:
> +      Extra GPIO line connected to DOUT/DRDY (Data Out/Data Ready). This allows
> +      distinguishing between interrupts triggered by the data-ready signal and
> +      interrupts triggered by an SPI transfer.
> +    maxItems: 1
> +
> +  '#io-channel-cells':
> +    const: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - vdd-supply
> +
> +allOf:
> +  - $ref: /schemas/spi/spi-peripheral-props.yaml#
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    spi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        adc@0 {
> +            compatible = "ti,ads1118";
> +            reg = <0>;
> +
> +            spi-max-frequency = <4000000>;
> +            spi-cpha;
> +
> +            vdd-supply = <&vdd_3v3_reg>;
> +
> +            interrupts-extended = <&gpio 14 IRQ_TYPE_EDGE_FALLING>;
> +            drdy-gpios = <&gpio 14 GPIO_ACTIVE_LOW>;
> +        };
> +    };