linux-kernel - Re: [RFC PATCH 1/3] staging: iio: ad9832: remove platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251207124625.5db016cb@jic23-huawei>
Date: Sun, 7 Dec 2025 12:46:25 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...el.com>
Cc: Tomas Borquez <tomasborquez13@...il.com>, Lars-Peter Clausen
 <lars@...afoo.de>, Michael Hennerich <Michael.Hennerich@...log.com>, Rob
 Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor
 Dooley <conor+dt@...nel.org>, Greg Kroah-Hartman
 <gregkh@...uxfoundation.org>, David Lechner <dlechner@...libre.com>, Nuno
 Sá <nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>,
 linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [RFC PATCH 1/3] staging: iio: ad9832: remove platform_data
 support

On Sat, 6 Dec 2025 18:24:18 +0200
Andy Shevchenko <andriy.shevchenko@...el.com> wrote:

> On Fri, Dec 05, 2025 at 05:27:41PM -0300, Tomas Borquez wrote:
> > Remove legacy platform_data support as there are no in tree users and
> > this approach belongs to a long gone era. The policy decision on what
> > to output is a userspace problem, not something that should be provided
> > from firmware.
> > 
> > The driver now initializes the device to a safe state (SLEEP|RESET|CLR)
> > outputting nothing. Userspace can configure the desired frequencies and
> > phases via the existing sysfs attributes once the device is ready to be   
> 
> Tailing space on the above line (and the only line with this issue).
> 
> > used.
> > 
> > Original discussion started here [1].  
> 
> The change LGTM, Jonathan, can you amend the above and apply it?
> (Yes, I have read the discussion about removal the driver, but meanwhile
>  the change is good on itself even if we are going to remove the driver.
>  It just makes an additional harmless step in my opinion.)
OK done. Small side note. If adding comments to link tags (e.g. the [1])
then use #[1].

b4 otherwise picks the thing up as two link tags. At least I think that is
what caused:

  [PATCH RFC 1/3] staging: iio: ad9832: remove platform_data support
    + Reviewed-by: Andy Shevchenko <andriy.shevchenko@...el.com>
    + Link: ... [1]

Looks like something stripped the extra space anyway when I was applying.
I didn't bother to check what.

Jonathan

> 
> FWIW,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...el.com>
>