linux-kernel - Re: [PATCH v3 1/3] dt-bindings: iio: adc: Add AD4134

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251207132205.402f36d4@jic23-huawei>
Date: Sun, 7 Dec 2025 13:22:05 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Marcelo Schmitt <marcelo.schmitt@...log.com>
Cc: <linux-iio@...r.kernel.org>, <devicetree@...r.kernel.org>,
 <linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <nuno.sa@...log.com>, <dlechner@...libre.com>, <andy@...nel.org>,
 <Michael.Hennerich@...log.com>, <robh@...nel.org>, <krzk+dt@...nel.org>,
 <conor+dt@...nel.org>, <corbet@....net>, <marcelo.schmitt1@...il.com>,
 Conor Dooley <conor.dooley@...rochip.com>
Subject: Re: [PATCH v3 1/3] dt-bindings: iio: adc: Add AD4134

On Tue, 2 Dec 2025 17:55:03 -0300
Marcelo Schmitt <marcelo.schmitt@...log.com> wrote:

> Add device tree documentation for AD4134 24-Bit, 4-channel simultaneous
> sampling, precision ADC.
> 
> Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>
> Signed-off-by: Marcelo Schmitt <marcelo.schmitt@...log.com>
A few comments inline. Not necessarily anything to change.

Thanks

Jonathan

> ---
> Change log v2 -> v3:
> - fixed typo in powerdown-gpios description.
> - picked up Conor's review tag. 
> 
>  .../bindings/iio/adc/adi,ad4134.yaml          | 198 ++++++++++++++++++
>  MAINTAINERS                                   |   7 +
>  2 files changed, 205 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad4134.yaml
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad4134.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad4134.yaml
> new file mode 100644
> index 000000000000..69a6ddf6ca92
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad4134.yaml

>
> +allOf:
> +  - if:
> +      not:
> +        required:
> +          - ldoin-supply
> +    then:
> +      required:
> +        - avdd1v8-supply
> +        - dvdd1v8-supply
> +        - clkvdd-supply

Conor gave a tag, so I'm sure this is fine, but could we do this as
a oneOf given it's a pick between two options?

> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    spi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        adc@0 {
> +            compatible = "adi,ad4134";
> +            reg = <0>;
> +
> +            spi-max-frequency = <1000000>;
> +
> +            reset-gpios = <&gpio0 86 GPIO_ACTIVE_LOW>;
> +            odr-gpios = <&gpio0 87 GPIO_ACTIVE_HIGH>;
> +            powerdown-gpios = <&gpio0 88 GPIO_ACTIVE_LOW>;
> +
> +            clocks = <&sys_clk>;
> +            clock-names = "clkin";
> +
> +            avdd5-supply = <&avdd5>;
> +            dvdd5-supply = <&dvdd5>;
> +            iovdd-supply = <&iovdd>;
> +            refin-supply = <&refin>;
> +            avdd1v8-supply = <&avdd1v8>;
> +            dvdd1v8-supply = <&dvdd1v8>;
> +            clkvdd-supply = <&clkvdd>;
> +
> +            adi,asrc-mode = "low";
> +            adi,dclkio = "in";
> +            adi,dclkmode = "gated";

Interesting question on whether it is worth adding properties
to examples if they are set to the defaults. Generally we wouldn't
expect actual DT files to set them.  Meh, doesn't matter much to me
either way!

> +
> +            regulators {
> +                vcm_reg: vcm-output {
> +                    regulator-name = "ad4134-vcm";
> +                };
> +            };
> +
> +        };
> +    };
> +...