linux-kernel - Re: [PATCH v3 3/3] Docs: iio: Add AD4134

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251207132850.1b0f8f71@jic23-huawei>
Date: Sun, 7 Dec 2025 13:28:50 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Marcelo Schmitt <marcelo.schmitt1@...il.com>
Cc: Tomas Melin <tomas.melin@...sala.com>, Marcelo Schmitt
 <marcelo.schmitt@...log.com>, linux-iio@...r.kernel.org,
 devicetree@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org, nuno.sa@...log.com, dlechner@...libre.com,
 andy@...nel.org, Michael.Hennerich@...log.com, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, corbet@....net
Subject: Re: [PATCH v3 3/3] Docs: iio: Add AD4134

On Fri, 5 Dec 2025 09:32:04 -0300
Marcelo Schmitt <marcelo.schmitt1@...il.com> wrote:

> On 12/05, Tomas Melin wrote:
> > Hi,
> > 
> > On 04/12/2025 17:32, Marcelo Schmitt wrote:  
> > > On 12/03, Tomas Melin wrote:  
> > >> Hi,
> > >>
> > >> On 02/12/2025 22:55, Marcelo Schmitt wrote:  
> > >>> Add initial documentation for the ad4134 IIO driver.  
> > >>
> > >> I wonder is there some information in here that is not readily available
> > >> in the device datasheet? After all, isn't idea with this file to
> > >> document peculiarities that are not easily found elsewhere?  
> > > 
> > > You are correct, these docs are mostly from data sheet info.
> > > The main idea of having the doc is to make clear what peripheral connection
> > > schema is currently supported.
> > > Because AD4134 is both flexible and somewhat extensible in the way it can be
> > > connected to the host, we could have different wiring configurations, for
> > > example  
> > 
> > Thanks for your explanation. My humble opinion is that it would be
> > enough to mention in the commit message for the driver being added, or
> > in the device-tree bindings that basic I/O mode is only configuration
> > that is currently supported.  
> 
> Okay, I'll drop the docs from v4.
> 
On this: I only rarely request docs for a particular driver when
it gets really complex - particularly when the ABI might not obviously
align with the terminology in a datasheet.

For other drivers I've always taken the view that if the documentation
is clean and potentially useful I don't mind adding it.

I get Tomas' point here though as this is very light so maybe a 'not yet'.

Jonathan


> Thanks,
> Marcelo