linux-kernel - Re: [PATCH] dmaengine: dw-edma: Fix confusing cleanup.h syntax

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <jbaurqrdhdgj4jw6jupcbxrs4w7xceyjd2ilfhtcr42hdj4etl@z4uyjmzypsti>
Date: Mon, 8 Dec 2025 14:17:31 +0900
From: Manivannan Sadhasivam <mani@...nel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>
Cc: Vinod Koul <vkoul@...nel.org>, dmaengine@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dmaengine: dw-edma: Fix confusing cleanup.h syntax

On Mon, Dec 08, 2025 at 03:07:30AM +0100, Krzysztof Kozlowski wrote:
> Initializing automatic __free variables to NULL without need (e.g.
> branches with different allocations), followed by actual allocation is
> in contrary to explicit coding rules guiding cleanup.h:
> 
> "Given that the "__free(...) = NULL" pattern for variables defined at
> the top of the function poses this potential interdependency problem the
> recommendation is to always define and assign variables in one statement
> and not group variable definitions at the top of the function when
> __free() is used."
> 
> Code does not have a bug, but is less readable and uses discouraged
> coding practice, so fix that by moving declaration to the place of
> assignment.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>

Reviewed-by: Manivannan Sadhasivam <mani@...nel.org>

- Mani

> ---
>  drivers/dma/dw-edma/dw-edma-pcie.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c
> index 3371e0a76d3c..e9caf8adca1f 100644
> --- a/drivers/dma/dw-edma/dw-edma-pcie.c
> +++ b/drivers/dma/dw-edma/dw-edma-pcie.c
> @@ -161,13 +161,13 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev,
>  			      const struct pci_device_id *pid)
>  {
>  	struct dw_edma_pcie_data *pdata = (void *)pid->driver_data;
> -	struct dw_edma_pcie_data *vsec_data __free(kfree) = NULL;
>  	struct device *dev = &pdev->dev;
>  	struct dw_edma_chip *chip;
>  	int err, nr_irqs;
>  	int i, mask;
>  
> -	vsec_data = kmalloc(sizeof(*vsec_data), GFP_KERNEL);
> +	struct dw_edma_pcie_data *vsec_data __free(kfree) =
> +		kmalloc(sizeof(*vsec_data), GFP_KERNEL);
>  	if (!vsec_data)
>  		return -ENOMEM;
>  
> -- 
> 2.51.0
> 

-- 
மணிவண்ணன் சதாசிவம்