linux-kernel - Re: [PATCH] dmaengine: dw-edma: Fix confusing cleanup.h syntax

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <176590436343.430148.178908996367705335.b4-ty@kernel.org>
Date: Tue, 16 Dec 2025 22:29:23 +0530
From: Vinod Koul <vkoul@...nel.org>
To: Manivannan Sadhasivam <mani@...nel.org>, dmaengine@...r.kernel.org, 
 linux-kernel@...r.kernel.org, 
 Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>
Subject: Re: [PATCH] dmaengine: dw-edma: Fix confusing cleanup.h syntax


On Mon, 08 Dec 2025 03:07:30 +0100, Krzysztof Kozlowski wrote:
> Initializing automatic __free variables to NULL without need (e.g.
> branches with different allocations), followed by actual allocation is
> in contrary to explicit coding rules guiding cleanup.h:
> 
> "Given that the "__free(...) = NULL" pattern for variables defined at
> the top of the function poses this potential interdependency problem the
> recommendation is to always define and assign variables in one statement
> and not group variable definitions at the top of the function when
> __free() is used."
> 
> [...]

Applied, thanks!

[1/1] dmaengine: dw-edma: Fix confusing cleanup.h syntax
      commit: f9ef8dedee34e2d7828d5a6a0643cd969aaa8437

Best regards,
-- 
~Vinod