linux-kernel - Re: [PATCH 7/9] gpu: nova-core: firmware: fwsec: do not require bound device when unneeded

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6da7ff0ff31c1f4250b8d6cd1b535bd69322d0c9.camel@nvidia.com>
Date: Mon, 8 Dec 2025 16:18:07 +0000
From: Timur Tabi <ttabi@...dia.com>
To: Alexandre Courbot <acourbot@...dia.com>, "dakr@...nel.org"
	<dakr@...nel.org>, "aliceryhl@...gle.com" <aliceryhl@...gle.com>,
	"airlied@...il.com" <airlied@...il.com>, "simona@...ll.ch" <simona@...ll.ch>
CC: Alistair Popple <apopple@...dia.com>, John Hubbard <jhubbard@...dia.com>,
	Edwin Peer <epeer@...dia.com>, "dri-devel@...ts.freedesktop.org"
	<dri-devel@...ts.freedesktop.org>, "rust-for-linux@...r.kernel.org"
	<rust-for-linux@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "nouveau@...ts.freedesktop.org"
	<nouveau@...ts.freedesktop.org>, Joel Fernandes <joelagnelf@...dia.com>
Subject: Re: [PATCH 7/9] gpu: nova-core: firmware: fwsec: do not require bound
 device when unneeded

On Mon, 2025-12-08 at 18:26 +0900, Alexandre Courbot wrote:
>      /// Loads the FWSEC firmware into `falcon` and execute it.
> -    pub(crate) fn run(
> -        &self,
> -        dev: &Device<device::Bound>,
> -        falcon: &Falcon<Gsp>,
> -        bar: &Bar0,
> -    ) -> Result<()> {
> +    pub(crate) fn run(&self, dev: &Device, falcon: &Falcon<Gsp>, bar: &Bar0) -> Result<()> {

I frequently see patches that, when they change the function signature, rearrange the parameters
from one line to multiple lines.  Here, you are doing the opposite.  Not only that, but it seems
unnecessary because you're actually just changing one parameter, so you should only be replacing
one line.

It seems to me that some people have their editors configured to prefer one line, and others
have their editor configured to prefer multiple lines, so whenever there's a signature change,
we get diffs like this.