linux-kernel - Re: [PATCH 7/9] gpu: nova-core: firmware: fwsec: do not require bound device when unneeded

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <835a223c-e738-4804-b7db-2b24ad37410b@nvidia.com>
Date: Mon, 8 Dec 2025 08:51:40 -0800
From: John Hubbard <jhubbard@...dia.com>
To: Timur Tabi <ttabi@...dia.com>, Alexandre Courbot <acourbot@...dia.com>,
 "dakr@...nel.org" <dakr@...nel.org>,
 "aliceryhl@...gle.com" <aliceryhl@...gle.com>,
 "airlied@...il.com" <airlied@...il.com>, "simona@...ll.ch" <simona@...ll.ch>
Cc: Alistair Popple <apopple@...dia.com>, Edwin Peer <epeer@...dia.com>,
 "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
 "rust-for-linux@...r.kernel.org" <rust-for-linux@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "nouveau@...ts.freedesktop.org" <nouveau@...ts.freedesktop.org>,
 Joel Fernandes <joelagnelf@...dia.com>
Subject: Re: [PATCH 7/9] gpu: nova-core: firmware: fwsec: do not require bound
 device when unneeded

On 12/8/25 8:18 AM, Timur Tabi wrote:
> On Mon, 2025-12-08 at 18:26 +0900, Alexandre Courbot wrote:
...
> I frequently see patches that, when they change the function signature, rearrange the parameters
> from one line to multiple lines.  Here, you are doing the opposite.  Not only that, but it seems
> unnecessary because you're actually just changing one parameter, so you should only be replacing
> one line.
> 
> It seems to me that some people have their editors configured to prefer one line, and others
> have their editor configured to prefer multiple lines, so whenever there's a signature change,
> we get diffs like this.

Nope, what's actually happening is that (nearly) everyone has
their editor set up to run rustfmt(1) upon file save. That's
the convention used in Rust for Linux. (Failing that, one is
expected to run rustfmt before posting.)

It is a little jumpy, as you can see above, but it does have
the nice property of avoiding formatting discussions, since
there is only one way for things to end up.

thanks,
-- 
John Hubbard