linux-kernel - Re: [PATCH] ACPI: processor: idle: Add debug log for the state whose entry method is illegal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251208163459.00000842@huawei.com>
Date: Mon, 8 Dec 2025 16:35:15 +0000
From: Jonathan Cameron <jonathan.cameron@...wei.com>
To: Huisong Li <lihuisong@...wei.com>, <linuxarm@...wei.com>
CC: <rafael@...nel.org>, <lenb@...nel.org>, <linux-acpi@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <Sudeep.Holla@....com>,
	<jonathan.cameron@...wei.com>, <zhanjie9@...ilicon.com>,
	<zhenglifeng1@...wei.com>, <yubowen8@...wei.com>
Subject: Re: [PATCH] ACPI: processor: idle: Add debug log for the state
 whose entry method is illegal

On Tue, 25 Nov 2025 14:47:02 +0800
Huisong Li <lihuisong@...wei.com> wrote:

> According to ACPI spec, entry method in LPI sub-package must be buffer
> or integer. Driver will disable the state whose the entry method is
> illegal by zero flags in struct acpi_lpi_state. The entry method is
> very key in cpuidle. A debug log is very useful developers.
> 
> Signed-off-by: Huisong Li <lihuisong@...wei.com>
Seems reasonable to me and debug is probably appropriate error for broken
firmware. 
Reviewed-by: Jonathan Cameron <jonathan.cameron@...wei.com>

> ---
>  drivers/acpi/processor_idle.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
> index 22909fccf0b1..5f86297c8b23 100644
> --- a/drivers/acpi/processor_idle.c
> +++ b/drivers/acpi/processor_idle.c
> @@ -946,6 +946,8 @@ static int acpi_processor_evaluate_lpi(acpi_handle handle,
>  			lpi_state->entry_method = ACPI_CSTATE_INTEGER;
>  			lpi_state->address = obj->integer.value;
>  		} else {
> +			pr_debug("Entry method of state-%d is illegal, disable it.\n",
> +				 state_idx);
>  			continue;
>  		}
>