linux-kernel - Re: [PATCH] ACPI: processor: idle: Add debug log for the state whose entry method is illegal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0hh79=BgBDAvYE1L3ncX58Mn=U53N_rYhA1a8ObAn_OiQ@mail.gmail.com>
Date: Wed, 14 Jan 2026 17:48:06 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Jonathan Cameron <jonathan.cameron@...wei.com>, Huisong Li <lihuisong@...wei.com>
Cc: linuxarm@...wei.com, linux-acpi@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Sudeep.Holla@....com, zhanjie9@...ilicon.com, 
	zhenglifeng1@...wei.com, yubowen8@...wei.com
Subject: Re: [PATCH] ACPI: processor: idle: Add debug log for the state whose
 entry method is illegal

On Mon, Dec 8, 2025 at 5:35 PM Jonathan Cameron
<jonathan.cameron@...wei.com> wrote:
>
> On Tue, 25 Nov 2025 14:47:02 +0800
> Huisong Li <lihuisong@...wei.com> wrote:
>
> > According to ACPI spec, entry method in LPI sub-package must be buffer
> > or integer. Driver will disable the state whose the entry method is
> > illegal by zero flags in struct acpi_lpi_state. The entry method is
> > very key in cpuidle. A debug log is very useful developers.
> >
> > Signed-off-by: Huisong Li <lihuisong@...wei.com>
> Seems reasonable to me and debug is probably appropriate error for broken
> firmware.
> Reviewed-by: Jonathan Cameron <jonathan.cameron@...wei.com>

Applied as 6.20 material, thanks!

> > ---
> >  drivers/acpi/processor_idle.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
> > index 22909fccf0b1..5f86297c8b23 100644
> > --- a/drivers/acpi/processor_idle.c
> > +++ b/drivers/acpi/processor_idle.c
> > @@ -946,6 +946,8 @@ static int acpi_processor_evaluate_lpi(acpi_handle handle,
> >                       lpi_state->entry_method = ACPI_CSTATE_INTEGER;
> >                       lpi_state->address = obj->integer.value;
> >               } else {
> > +                     pr_debug("Entry method of state-%d is illegal, disable it.\n",
> > +                              state_idx);
> >                       continue;
> >               }
> >
>