linux-kernel - Re: [PATCH v3 02/10] crypto: virtio: Remove duplicated virtqueue_kick in virtio_crypto_skcipher_crypt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACGkMEviPVi+nJvS6rU55vF8xk08kAkr6ja0tYZp3BHJK=LtJQ@mail.gmail.com>
Date: Tue, 9 Dec 2025 12:32:23 +0800
From: Jason Wang <jasowang@...hat.com>
To: Bibo Mao <maobibo@...ngson.cn>
Cc: Gonglei <arei.gonglei@...wei.com>, "Michael S . Tsirkin" <mst@...hat.com>, 
	Xuan Zhuo <xuanzhuo@...ux.alibaba.com>, Eugenio Pérez <eperezma@...hat.com>, 
	Herbert Xu <herbert@...dor.apana.org.au>, "David S. Miller" <davem@...emloft.net>, 
	virtualization@...ts.linux.dev, linux-crypto@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 02/10] crypto: virtio: Remove duplicated virtqueue_kick
 in virtio_crypto_skcipher_crypt_req

On Tue, Dec 9, 2025 at 12:31 PM Jason Wang <jasowang@...hat.com> wrote:
>
> On Tue, Dec 9, 2025 at 10:00 AM Bibo Mao <maobibo@...ngson.cn> wrote:
> >
> > With function virtio_crypto_skcipher_crypt_req(), there is already
> > virtqueue_kick() call with spinlock held in funtion
>
> A typo should be "function".
>
> > __virtio_crypto_skcipher_do_req(). Remove duplicated virtqueue_kick()
> > function call here.
> >
> > Signed-off-by: Bibo Mao <maobibo@...ngson.cn>
>
> Acked-by: Jason Wang <jasowang@...hat.com>

Btw.

I think this probably deserved a stable tag as well as the
virtqueue_kick is not synchronized here?

>
> Thanks

Thanks