linux-kernel - Re: [PATCH v3 02/10] crypto: virtio: Remove duplicated virtqueue_kick in virtio_crypto_skcipher_crypt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f56218d3-b1c2-5ff8-a0c2-33683c3caef8@loongson.cn>
Date: Wed, 10 Dec 2025 09:20:20 +0800
From: Bibo Mao <maobibo@...ngson.cn>
To: Jason Wang <jasowang@...hat.com>
Cc: Gonglei <arei.gonglei@...wei.com>, "Michael S . Tsirkin"
 <mst@...hat.com>, Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
 Eugenio Pérez <eperezma@...hat.com>,
 Herbert Xu <herbert@...dor.apana.org.au>,
 "David S. Miller" <davem@...emloft.net>, virtualization@...ts.linux.dev,
 linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 02/10] crypto: virtio: Remove duplicated virtqueue_kick
 in virtio_crypto_skcipher_crypt_req

On 2025/12/9 下午12:32, Jason Wang wrote:
> On Tue, Dec 9, 2025 at 12:31 PM Jason Wang <jasowang@...hat.com> wrote:
>>
>> On Tue, Dec 9, 2025 at 10:00 AM Bibo Mao <maobibo@...ngson.cn> wrote:
>>>
>>> With function virtio_crypto_skcipher_crypt_req(), there is already
>>> virtqueue_kick() call with spinlock held in funtion
>>
>> A typo should be "function".
Good catch, will correct this.
>>
>>> __virtio_crypto_skcipher_do_req(). Remove duplicated virtqueue_kick()
>>> function call here.
>>>
>>> Signed-off-by: Bibo Mao <maobibo@...ngson.cn>
>>
>> Acked-by: Jason Wang <jasowang@...hat.com>
> 
> Btw.
> 
> I think this probably deserved a stable tag as well as the
> virtqueue_kick is not synchronized here?
sure, will do in next version.

Regards
Bibo Mao
> 
>>
>> Thanks
> 
> Thanks
>