linux-kernel - Re: PATCH] tracing: Fix unused tracepoints when module uses only exported ones

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251209202551.055c0f1b@fedora>
Date: Tue, 9 Dec 2025 20:25:51 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Cc: LKML <linux-kernel@...r.kernel.org>, Linux trace kernel
 <linux-trace-kernel@...r.kernel.org>, Masami Hiramatsu
 <mhiramat@...nel.org>, Masahiro Yamada <masahiroy@...nel.org>
Subject: Re: PATCH] tracing: Fix unused tracepoints when module uses only
 exported ones

On Mon, 8 Dec 2025 09:22:48 -0500
Mathieu Desnoyers <mathieu.desnoyers@...icios.com> wrote:

> On 2025-12-08 08:53, Steven Rostedt wrote:
> > From: Steven Rostedt <rostedt@...dmis.org>  
> 
> Missing bracket for [PATCH] in subject.
> 
> > 
> > Building the KVM intel module failed to build with UT=1:  
> 
> failed -> fails (present ?)

After the patch is applied it will be in the past ;-)
> 
> > 
> > no __tracepoint_strings in file: arch/x86/kvm/kvm-intel.o
> > make[3]: *** [/work/git/test-linux.git/scripts/Makefile.modfinal:62: arch/x86/kvm/kvm-intel.ko] Error 1
> > 
> > The reason is that the module only uses the tracepoints defined and
> > exported by the main kvm module. The tracepoint-udpate.c code fails the  
> 
> I guess you mean "tracepoint-update.c" ?

Oops

> 
> > build if a tracepoint is used, but there's no tracepoints defined. But  
> 
> tracepoint

Actually, plural is fine here. Because it means one or more here.


> 
> > this is acceptable in modules if the tracepoints is defined in the vmlinux  
> 
> tracepoint

Actually, it should stay plural (as it is more than one), but needs s/is/are/

> 
> > proper or another module and exported.
> > 
> > Do not fail to build if a tracepoint is used but no tracepoints are  
> 
> tracepoint .. is
> 

Again, plural is OK here, but the other fixes can be done.

Although I see this right after I send a pull request to Linus, but
because I'm currently at the Maintainers Summit with Linus, and I don't
need to test this to fix it, I'll set up another pull request and tell
him to take the second one.

Thanks,

-- Steve


But, because it's just a change log fix and