linux-kernel - RE: [PATCH v2 1/2] EDAC/i5000: Fix snprintf() size calculation in calculate_dimm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CY8PR11MB71346AB33091B972A39F841789A0A@CY8PR11MB7134.namprd11.prod.outlook.com>
Date: Wed, 10 Dec 2025 01:26:59 +0000
From: "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>
To: Dan Carpenter <dan.carpenter@...aro.org>, Mauro Carvalho Chehab
	<mchehab@...nel.org>
CC: Borislav Petkov <bp@...en8.de>, "Luck, Tony" <tony.luck@...el.com>,
	Aristeu Rozanski <arozansk@...hat.com>, "linux-edac@...r.kernel.org"
	<linux-edac@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 1/2] EDAC/i5000: Fix snprintf() size calculation in
 calculate_dimm_size()

> From: Dan Carpenter <dan.carpenter@...aro.org>
> Sent: Tuesday, December 9, 2025 10:37 PM
> To: Mauro Carvalho Chehab <mchehab@...nel.org>
> Cc: Borislav Petkov <bp@...en8.de>; Luck, Tony <tony.luck@...el.com>;
> Aristeu Rozanski <arozansk@...hat.com>; linux-edac@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Subject: [PATCH v2 1/2] EDAC/i5000: Fix snprintf() size calculation in
> calculate_dimm_size()
> 
> The snprintf() can't really overflow because we're writing a max of 42 bytes to
> a PAGE_SIZE buffer.  But the limit calculation doesn't take the first 11 bytes
> that we wrote into consideration so the limit is not correct.  Just fix it for
> correctness even though it doesn't affect runtime.
> 
> Fixes: 64e1fdaf55d6 ("i5000_edac: Fix the logic that retrieves memory
> information")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

LGTM. Thanks.

  Reviewed-by: Qiuxu Zhuo <qiuxu.zhuo@...el.com>