linux-kernel - [PATCH v2] mm/damon/sysfs-schemes: Remove outdated TODO in target_nid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251211030707.16417-2-swarajgaikwad1925@gmail.com>
Date: Thu, 11 Dec 2025 03:07:08 +0000
From: Swaraj Gaikwad <swarajgaikwad1925@...il.com>
To: sj@...nel.org
Cc: akpm@...ux-foundation.org,
	damon@...ts.linux.dev,
	david.hunter.linux@...il.com,
	linux-kernel@...r.kernel.org,
	linux-mm@...ck.org,
	skhan@...uxfoundation.org,
	swarajgaikwad1925@...il.com
Subject: [PATCH v2] mm/damon/sysfs-schemes: Remove outdated TODO in target_nid_store()

The TODO comment in target_nid_store() suggested adding range validation
for target_nid. As discussed in [1], the current behavior of accepting
any integer value is intentional. DAMON sysfs aims to remain flexible,
including supporting users who prepare node IDs before future NUMA hotplug
events.

Because this behavior matches the broader design philosophy of the DAMON
sysfs interface, the TODO comment is now misleading. This patch removes the
comment.

No functional changes.

[1] https://lore.kernel.org/lkml/20251210150930.57679-1-sj@kernel.org/

v2:
 - Removed the logic changes (validation) introduced in v1.
 - Updated commit message to reflect that only the comment is being removed.

Suggested-by: SeongJae Park <sj@...nel.org>
Signed-off-by: Swaraj Gaikwad <swarajgaikwad1925@...il.com>
---
 mm/damon/sysfs-schemes.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/mm/damon/sysfs-schemes.c b/mm/damon/sysfs-schemes.c
index 6536f16006c9..14a17da350ab 100644
--- a/mm/damon/sysfs-schemes.c
+++ b/mm/damon/sysfs-schemes.c
@@ -2245,7 +2245,6 @@ static ssize_t target_nid_store(struct kobject *kobj,
 			struct damon_sysfs_scheme, kobj);
 	int err = 0;

-	/* TODO: error handling for target_nid range. */
 	err = kstrtoint(buf, 0, &scheme->target_nid);

 	return err ? err : count;

base-commit: e9a6fb0bcdd7609be6969112f3fbfcce3b1d4a7c
--
2.52.0