linux-kernel - Re: [PATCH v2] mm/damon/sysfs-schemes: Remove outdated TODO in target_nid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251210214939.62774-1-sj@kernel.org>
Date: Wed, 10 Dec 2025 13:49:39 -0800
From: SeongJae Park <sj@...nel.org>
To: Swaraj Gaikwad <swarajgaikwad1925@...il.com>
Cc: SeongJae Park <sj@...nel.org>,
	akpm@...ux-foundation.org,
	damon@...ts.linux.dev,
	david.hunter.linux@...il.com,
	linux-kernel@...r.kernel.org,
	linux-mm@...ck.org,
	skhan@...uxfoundation.org
Subject: Re: [PATCH v2] mm/damon/sysfs-schemes: Remove outdated TODO in target_nid_store()

On Thu, 11 Dec 2025 03:07:08 +0000 Swaraj Gaikwad <swarajgaikwad1925@...il.com> wrote:

> The TODO comment in target_nid_store() suggested adding range validation
> for target_nid. As discussed in [1], the current behavior of accepting
> any integer value is intentional. DAMON sysfs aims to remain flexible,
> including supporting users who prepare node IDs before future NUMA hotplug
> events.
> 
> Because this behavior matches the broader design philosophy of the DAMON
> sysfs interface, the TODO comment is now misleading. This patch removes the
> comment.

Thank you so much for this patch, Swaraj!

You sent this as a reply to v1.  In mm/ and damon/ subsystems, we prefer new
versions of patches to be sent as a new email, rather than a reply to the
previous version.  Please consider doing so next time.

> 
> No functional changes.
> 
> [1] https://lore.kernel.org/lkml/20251210150930.57679-1-sj@kernel.org/

This kind of link is useful for tracking the history.  Thank you for adding
this.

> 
> v2:
>  - Removed the logic changes (validation) introduced in v1.
>  - Updated commit message to reflect that only the comment is being removed.

This kind of change history should be placed under the '---' line [1] below.
Please consider doing so next time.

> 
> Suggested-by: SeongJae Park <sj@...nel.org>
> Signed-off-by: Swaraj Gaikwad <swarajgaikwad1925@...il.com>

Other than the trivial comments above, change looks good to me.

Reviewed-by: SeongJae Park <sj@...nel.org>

If you willing to, please address the comments and send v3.  Because the
comments are for only very trivial things, if you don't or can't do that in
days, I will address those and send it as v3 on my own.

[1] https://docs.kernel.org/process/submitting-patches.html#commentary

Thanks,
SJ

[...]