linux-kernel - Re: [PATCH 2/2] arm64: dts: freescale: imx95: Add support for i.MX95 15x15 FRDM board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aTkbyAHjrwzTsfO8@lsvm07u0000156.swis.us-west-2.aws.nxp.com>
Date: Tue, 9 Dec 2025 23:05:44 -0800
From: Lei Xu <lei.xu@....com>
To: Francesco Dolcini <francesco@...cini.it>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, imx@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org, justin.jiang@....com,
	qijian.guo@....com
Subject: Re: [PATCH 2/2] arm64: dts: freescale: imx95: Add support for i.MX95
 15x15 FRDM board

On Mon, Dec 08, 2025 at 07:57:07AM +0100, Francesco Dolcini wrote:
> Hello Lei,
> 
> On Sun, Dec 07, 2025 at 05:26:06AM -0800, Lei Xu wrote:
> > The i.MX95 15x15 FRDM board is a compact and cost-effective development
> > platform based on the i.MX95 applications processor.
> 
> ...
> 
> > diff --git a/arch/arm64/boot/dts/freescale/imx95-15x15-frdm.dts b/arch/arm64/boot/dts/freescale/imx95-15x15-frdm.dts
> > new file mode 100644
> > index 000000000000..61e815c858b8
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/freescale/imx95-15x15-frdm.dts
> 
> ...
> 
> > +
> > +/* Default settings in i.mx95.dtsi are for i.MX95 19x19 package.
> > + * Override here for the i.MX95 15x15 package.
> > + */
> > +&netc_bus0 {
> > +	msi-map = <0x0 &its 0x60 0x1>,	//ENETC0 PF
> > +		  <0x10 &its 0x61 0x1>, //ENETC0 VF0
> > +		  <0x20 &its 0x62 0x1>, //ENETC0 VF1
> > +		  <0x40 &its 0x63 0x1>, //ENETC1 PF
> > +		  <0x50 &its 0x65 0x1>, //ENETC1 VF0
> > +		  <0x60 &its 0x66 0x1>, //ENETC1 VF1
> > +		  <0x80 &its 0x64 0x1>, //ENETC2 PF
> > +		  <0xc0 &its 0x67 0x1>; //NETC Timer
> > +	iommu-map = <0x0 &smmu 0x20 0x1>,
> > +		    <0x10 &smmu 0x21 0x1>,
> > +		    <0x20 &smmu 0x22 0x1>,
> > +		    <0x40 &smmu 0x23 0x1>,
> > +		    <0x50 &smmu 0x25 0x1>,
> > +		    <0x60 &smmu 0x26 0x1>,
> > +		    <0x80 &smmu 0x24 0x1>,
> > +		    <0xc0 &smmu 0x27 0x1>;
> > +};
> 
> If the 19x19 and 15x15 i.MX95 requires something different you should
> have a different soc dtsi. Probably creating a new imx95-$something
> dtsi, that includes the existing imx95.dtsi and override this property.
> 
> This solution does not scale, please fix it.
> 
> Francesco
>

Hello, Francesco

The original comment is misleading because this configuration applies to the board rather than the SoC.
Therefore, update the comment as follows:
/*
 * Configure PCIe MSI and IOMMU mappings specific
 * to the i.MX95 15x15 FRDM board.
 */

Does this look acceptable to you? Thank you.

Lei