linux-kernel - Re: [PATCH] net: can: fix build dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251210-imported-pelican-from-tartarus-c1084f-mkl@pengutronix.de>
Date: Wed, 10 Dec 2025 09:16:39 +0100
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Vincent Mailhol <mailhol@...nel.org>
Cc: Arnd Bergmann <arnd@...nel.org>, 
	Oliver Hartkopp <socketcan@...tkopp.net>, Arnd Bergmann <arnd@...db.de>, 
	Jimmy Assarsson <extja@...ser.com>, linux-can@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: can: fix build dependency

On 05.12.2025 00:30:14, Vincent Mailhol wrote:
> > diff --git a/drivers/net/can/Kconfig b/drivers/net/can/Kconfig
> > index e15e320db476..bc074218d0ee 100644
> > --- a/drivers/net/can/Kconfig
> > +++ b/drivers/net/can/Kconfig
> > @@ -1,7 +1,7 @@
> >  # SPDX-License-Identifier: GPL-2.0-only
> >
> >  menuconfig CAN_DEV
> > -	tristate "CAN Device Drivers"
> > +	bool "CAN Device Drivers"
> >  	default y
> >  	depends on CAN
> >  	help
> > @@ -20,7 +20,7 @@ menuconfig CAN_DEV
> >  	  To compile as a module, choose M here: the module will be called
>                                   ^^^^^^^^
> After this change, it is not possible to "choose M" for CAN_DEV anymore. I would
> suggest to modify (or remove) the above sentence.

Removed the sentence why applying the patch.

>
> >  	  can-dev.> -if CAN_DEV
> > +if CAN_DEV && CAN
>               ^^^^^^
> Is this needed? CAN_DEV depends on CAN, so the condition
>
>   CAN_DEV && !CAN
>
> should not be reachable.

Removed the '&& CAN' while applying the patch.

Thanks,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)