linux-kernel - Re: [PATCH] net: can: fix build dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <7427949a-ea7d-4854-9fe4-e01db7d878c7@app.fastmail.com>
Date: Wed, 10 Dec 2025 10:10:27 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Marc Kleine-Budde" <mkl@...gutronix.de>,
 "Vincent Mailhol" <mailhol@...nel.org>
Cc: "Arnd Bergmann" <arnd@...nel.org>,
 "Oliver Hartkopp" <socketcan@...tkopp.net>,
 "Jimmy Assarsson" <extja@...ser.com>, linux-can@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: can: fix build dependency

On Wed, Dec 10, 2025, at 09:16, Marc Kleine-Budde wrote:
> On 05.12.2025 00:30:14, Vincent Mailhol wrote:

>> >  	  can-dev.> -if CAN_DEV
>> > +if CAN_DEV && CAN
>>               ^^^^^^
>> Is this needed? CAN_DEV depends on CAN, so the condition
>>
>>   CAN_DEV && !CAN
>>
>> should not be reachable.
>
> Removed the '&& CAN' while applying the patch.

Sorry I forgot to reply here: the '&& CAN' is absolutely
required here, otherwise you can configure CAN device drivers
as built-in with CAN_DEV=y CAN=m, and that results in a
link failure.

      Arnd