linux-kernel - Re: [PATCH] net: can: fix build dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251210-sassy-apricot-toad-239179-mkl@pengutronix.de>
Date: Wed, 10 Dec 2025 10:38:57 +0100
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Arnd Bergmann <arnd@...db.de>
Cc: Vincent Mailhol <mailhol@...nel.org>, Arnd Bergmann <arnd@...nel.org>, 
	Oliver Hartkopp <socketcan@...tkopp.net>, Jimmy Assarsson <extja@...ser.com>, linux-can@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: can: fix build dependency

On 10.12.2025 10:10:27, Arnd Bergmann wrote:
> On Wed, Dec 10, 2025, at 09:16, Marc Kleine-Budde wrote:
> > On 05.12.2025 00:30:14, Vincent Mailhol wrote:
>
> >> >  	  can-dev.> -if CAN_DEV
> >> > +if CAN_DEV && CAN
> >>               ^^^^^^
> >> Is this needed? CAN_DEV depends on CAN, so the condition
> >>
> >>   CAN_DEV && !CAN
> >>
> >> should not be reachable.
> >
> > Removed the '&& CAN' while applying the patch.
>
> Sorry I forgot to reply here: the '&& CAN' is absolutely
> required here, otherwise you can configure CAN device drivers
> as built-in with CAN_DEV=y CAN=m, and that results in a
> link failure.

You mean:

| $ grep ^CONFIG_CAN .config
| CONFIG_CAN=m
| CONFIG_CAN_RAW=m
| CONFIG_CAN_BCM=m
| CONFIG_CAN_GW=m
| CONFIG_CAN_DEV=y
| CONFIG_CAN_VXCAN=y
| CONFIG_CAN_NETLINK=y
| CONFIG_CAN_CALC_BITTIMING=y
| CONFIG_CAN_RX_OFFLOAD=y
| CONFIG_CAN_DUMMY=y
| CONFIG_CAN_GS_USB=y

...which works for me.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)