linux-kernel - Re: [PATCH] MIPS: Alchemy: Remove bogus static/inline specifiers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aTmiHFTh89QER5vG@alpha.franken.de>
Date: Wed, 10 Dec 2025 17:38:52 +0100
From: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To: Florian Fainelli <f.fainelli@...il.com>
Cc: Thierry Reding <thierry.reding@...il.com>,
	Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
	linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MIPS: Alchemy: Remove bogus static/inline specifiers

On Mon, Dec 08, 2025 at 10:16:29AM -0800, Florian Fainelli wrote:
> On 10/29/25 08:03, Thierry Reding wrote:
> > From: Thierry Reding <treding@...dia.com>
> > 
> > The recent io_remap_pfn_range() rework applied the static and inline
> > specifiers to the implementation of io_remap_pfn_range_pfn() on MIPS
> > Alchemy, mirroring the same change on other platforms. However, this
> > function is defined in a source file and that definition causes a
> > conflict with its declaration. Fix this by dropping the specifiers.
> > 
> > Fixes: 8efb51ad1b05 ("mm: abstract io_remap_pfn_range() based on PFN")
> > Signed-off-by: Thierry Reding <treding@...dia.com>
> 
> Tested-by: Florian Fainelli <f.fainelli@...il.com>
> Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
> 
> Thanks!
> 
> Thomas, can you pick this up so we have working alchemy builds again?

well, I've acked the patch for inclusion in the tree where the broken
commit was applied, but I could take it.

I'll correct the Fixes tag to

Fixes: c707a68f9468 ("mm: abstract io_remap_pfn_range() based on PFN")

when applying.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]