linux-kernel - Re: [PATCH 1/8] selftests: ublk: correct last_rw map type in seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aTqHnCSZMiobMtXL@fedora>
Date: Thu, 11 Dec 2025 16:58:04 +0800
From: Ming Lei <ming.lei@...hat.com>
To: Caleb Sander Mateos <csander@...estorage.com>
Cc: Shuah Khan <shuah@...nel.org>, linux-block@...r.kernel.org,
	linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/8] selftests: ublk: correct last_rw map type in
 seq_io.bt

On Wed, Dec 10, 2025 at 10:15:56PM -0700, Caleb Sander Mateos wrote:
> The last_rw map is initialized with a value of 0 but later assigned the
> value args.sector + args.nr_sector, which has type sector_t = u64.
> bpftrace complains about the type mismatch between int64 and uint64:
> trace/seq_io.bt:18:3-59: ERROR: Type mismatch for @last_rw: trying to assign value of type 'uint64' when map already contains a value of type 'int64'
>         @last_rw[$dev, str($2)] = (args.sector + args.nr_sector);
> 
> Cast the initial value to uint64 so bpftrace will load the program.
> 
> Signed-off-by: Caleb Sander Mateos <csander@...estorage.com>
> ---
>  tools/testing/selftests/ublk/trace/seq_io.bt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/ublk/trace/seq_io.bt b/tools/testing/selftests/ublk/trace/seq_io.bt
> index 272ac54c9d5f..507a3ca05abf 100644
> --- a/tools/testing/selftests/ublk/trace/seq_io.bt
> +++ b/tools/testing/selftests/ublk/trace/seq_io.bt
> @@ -2,11 +2,11 @@
>  	$1: 	dev_t
>  	$2: 	RWBS
>  	$3:     strlen($2)
>  */
>  BEGIN {
> -	@last_rw[$1, str($2)] = 0;
> +	@last_rw[$1, str($2)] = (uint64)0;

Reviewed-by: Ming Lei <ming.lei@...hat.com>


Thanks,
Ming