linux-kernel - Re: [PATCH v1 1/1] ASoC: Fix acronym for Intel Gemini Lake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251211151752.GA3592429@bhelgaas>
Date: Thu, 11 Dec 2025 09:17:52 -0600
From: Bjorn Helgaas <helgaas@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Cezary Rojewski <cezary.rojewski@...el.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
	Liam Girdwood <liam.r.girdwood@...ux.intel.com>,
	Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>,
	Bard Liao <yung-chuan.liao@...ux.intel.com>,
	Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
	Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
	Pierre-Louis Bossart <pierre-louis.bossart@...ux.dev>,
	Daniel Baluta <daniel.baluta@....com>, Takashi Iwai <tiwai@...e.de>,
	Mark Brown <broonie@...nel.org>,
	Amadeusz Sławiński <amadeuszx.slawinski@...ux.intel.com>,
	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-sound@...r.kernel.org, sound-open-firmware@...a-project.org
Subject: Re: [PATCH v1 1/1] ASoC: Fix acronym for Intel Gemini Lake

On Thu, Dec 11, 2025 at 03:32:04PM +0200, Andy Shevchenko wrote:
> On Thu, Dec 11, 2025 at 09:45:54AM +0100, Cezary Rojewski wrote:
> > On 2025-12-10 12:55 PM, Andy Shevchenko wrote:
> > > While the used GML is consistent with the pattern for other Intel * Lake
> > > SoCs, the de facto use is GLK. Update the acronym and users accordingly.

> > > -#define PCI_DEVICE_ID_INTEL_HDA_GML	0x3198
> > > +#define PCI_DEVICE_ID_INTEL_HDA_GLK	0x3198
> > 
> > If two #defines are no-go (PCI_DEVICE_ID_INTEL_HDA_GLK and _GML), then
> > perhaps at least a comment to the right of the ID mentioning the "GML" would
> > help.
> 
> Bjorn, are you agree on adding a comment to PCI IDs to point out that in a
> couple of Intel documents the machine's acronym is GML?

Sure, that would be fine.