linux-kernel - Re: [PATCH 5/5] media: platform: mtk-mdp3: Change cmdq_pkt_jump_rel() to cmdq_pkt_jump_rel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <380a7eee3a949a6fb28116820285cc895eb5d65b.camel@mediatek.com>
Date: Thu, 11 Dec 2025 17:37:15 +0000
From: Jason-JH Lin (林睿祥) <Jason-JH.Lin@...iatek.com>
To: "chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>, "AngeloGioacchino Del
 Regno" <angelogioacchino.delregno@...labora.com>, "robh@...nel.org"
	<robh@...nel.org>, "nicolas@...fresne.ca" <nicolas@...fresne.ca>,
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>, "jassisinghbrar@...il.com"
	<jassisinghbrar@...il.com>, "mchehab@...nel.org" <mchehab@...nel.org>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>
CC: "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
	Singo Chang (張興國) <Singo.Chang@...iatek.com>,
	Sirius Wang (王皓昱) <Sirius.Wang@...iatek.com>,
	"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
	Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@...iatek.com>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Paul-pl Chen (陳柏霖) <Paul-pl.Chen@...iatek.com>,
	Nancy Lin (林欣螢) <Nancy.Lin@...iatek.com>,
	"wenst@...omium.org" <wenst@...omium.org>,
	Xiandong Wang (王先冬)
	<Xiandong.Wang@...iatek.com>, "linux-mediatek@...ts.infradead.org"
	<linux-mediatek@...ts.infradead.org>,
	Moudy Ho (何宗原) <Moudy.Ho@...iatek.com>,
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 5/5] media: platform: mtk-mdp3: Change cmdq_pkt_jump_rel()
 to cmdq_pkt_jump_rel_temp()

On Tue, 2025-12-09 at 15:47 -0500, Nicolas Dufresne wrote:
> Hi,
> 
> 
> Le samedi 01 novembre 2025 à 00:02 +0800, Jason-JH Lin a écrit :
> > To facilitate the removal of the shift_pa parameter from
> > cmdq_pkt_jump_rel(), current users of cmdq_pkt_jump_rel() need to
> > transition to using cmdq_pkt_jump_rel_temp() before the API change
> > is implemented.
> > 
> > Signed-off-by: Jason-JH Lin <jason-jh.lin@...iatek.com>
> > Reviewed-by: AngeloGioacchino Del Regno
> > <angelogioacchino.delregno@...labora.com>
> > ---
> >  drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c
> > b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c
> > index d0b0b072f953..5fc9263ccb78 100644
> > --- a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c
> > +++ b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c
> > @@ -628,7 +628,7 @@ static struct mdp_cmdq_cmd
> > *mdp_cmdq_prepare(struct mdp_dev *mdp,
> >  		goto err_free_path;
> >  	}
> >  	cmdq_pkt_eoc(&cmd->pkt);
> > -	cmdq_pkt_jump_rel(&cmd->pkt, CMDQ_INST_SIZE, mdp-
> > >cmdq_shift_pa[pp_idx]);
> > +	cmdq_pkt_jump_rel_temp(&cmd->pkt, CMDQ_INST_SIZE, mdp-
> > >cmdq_shift_pa[pp_idx]);
> 
> I cannot take that right now in the media tree, as it won't build.
> Can the SoC
> maintainer help me know if I just leave that on hold, or perhaps
> you'd like to
> take it ? (or its in next, and I just have to wait for next udpate?)
> 
> I also doubt patch 4/5 is make much of a difference without the soc
> changes ?
> 

Hi Angelo,

Can you help us? Thanks!

Regards,
Jason-JH Lin

> regards,
> Nicolas