linux-kernel - Re: [PATCH 5/5] media: platform: mtk-mdp3: Change cmdq_pkt_jump_rel() to cmdq_pkt_jump_rel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e0144120e0943b94454b1cddd5359c34b5a15412.camel@ndufresne.ca>
Date: Tue, 09 Dec 2025 15:47:10 -0500
From: Nicolas Dufresne <nicolas@...fresne.ca>
To: Jason-JH Lin <jason-jh.lin@...iatek.com>, Rob Herring <robh@...nel.org>,
  Krzysztof Kozlowski	 <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Jassi Brar	 <jassisinghbrar@...il.com>, Chun-Kuang
 Hu <chunkuang.hu@...nel.org>,  AngeloGioacchino Del Regno
 <angelogioacchino.delregno@...labora.com>, Mauro Carvalho Chehab
 <mchehab@...nel.org>
Cc: Matthias Brugger <matthias.bgg@...il.com>, Nancy Lin	
 <nancy.lin@...iatek.com>, Singo Chang <singo.chang@...iatek.com>, Paul-PL
 Chen	 <paul-pl.chen@...iatek.com>, Moudy Ho <moudy.ho@...iatek.com>,
 Xiandong Wang	 <xiandong.wang@...iatek.com>, Sirius Wang
 <sirius.wang@...iatek.com>, Fei Shao	 <fshao@...omium.org>, Chen-yu Tsai
 <wenst@...omium.org>, 	Project_Global_Chrome_Upstream_Group@...iatek.com,
 devicetree@...r.kernel.org, 	linux-kernel@...r.kernel.org,
 dri-devel@...ts.freedesktop.org, 	linux-mediatek@...ts.infradead.org,
 linux-arm-kernel@...ts.infradead.org, 	linux-media@...r.kernel.org
Subject: Re: [PATCH 5/5] media: platform: mtk-mdp3: Change
 cmdq_pkt_jump_rel() to cmdq_pkt_jump_rel_temp()

Hi,


Le samedi 01 novembre 2025 à 00:02 +0800, Jason-JH Lin a écrit :
> To facilitate the removal of the shift_pa parameter from
> cmdq_pkt_jump_rel(), current users of cmdq_pkt_jump_rel() need to
> transition to using cmdq_pkt_jump_rel_temp() before the API change
> is implemented.
> 
> Signed-off-by: Jason-JH Lin <jason-jh.lin@...iatek.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> ---
>  drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c
> index d0b0b072f953..5fc9263ccb78 100644
> --- a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c
> +++ b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c
> @@ -628,7 +628,7 @@ static struct mdp_cmdq_cmd *mdp_cmdq_prepare(struct mdp_dev *mdp,
>  		goto err_free_path;
>  	}
>  	cmdq_pkt_eoc(&cmd->pkt);
> -	cmdq_pkt_jump_rel(&cmd->pkt, CMDQ_INST_SIZE, mdp->cmdq_shift_pa[pp_idx]);
> +	cmdq_pkt_jump_rel_temp(&cmd->pkt, CMDQ_INST_SIZE, mdp->cmdq_shift_pa[pp_idx]);

I cannot take that right now in the media tree, as it won't build. Can the SoC
maintainer help me know if I just leave that on hold, or perhaps you'd like to
take it ? (or its in next, and I just have to wait for next udpate?)

I also doubt patch 4/5 is make much of a difference without the soc changes ?

regards,
Nicolas

>  
>  	for (i = 0; i < num_comp; i++) {
>  		s32 inner_id = MDP_COMP_NONE;

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)