linux-kernel - Re: [PATCH v2 2/2] media: mediatek: amend vpu_get_plat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <836bcbc3e35c267abd93a4d2174a3e570ca9e181.camel@ndufresne.ca>
Date: Tue, 09 Dec 2025 15:43:30 -0500
From: Nicolas Dufresne <nicolas@...fresne.ca>
To: Johan Hovold <johan@...nel.org>, Minghsiu Tsai
 <minghsiu.tsai@...iatek.com>,  Houlong Wei <houlong.wei@...iatek.com>,
 Andrew-CT Chen <andrew-ct.chen@...iatek.com>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>, Matthias Brugger
	 <matthias.bgg@...il.com>, AngeloGioacchino Del Regno
	 <angelogioacchino.delregno@...labora.com>, Tiffany Lin
	 <tiffany.lin@...iatek.com>, Yunfei Dong <yunfei.dong@...iatek.com>, 
	linux-media@...r.kernel.org, linux-mediatek@...ts.infradead.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] media: mediatek: amend vpu_get_plat_device()
 documentation

Hi,

Le mardi 28 octobre 2025 à 11:04 +0100, Johan Hovold a écrit :
> Add a comment to the vpu_get_plat_device() documentation to make it
> clear that the VPU platform device is returned with an incremented
> reference count (which needs to be dropped after use).
> 
> Signed-off-by: Johan Hovold <johan@...nel.org>
> ---
>  drivers/media/platform/mediatek/vpu/mtk_vpu.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/mediatek/vpu/mtk_vpu.h b/drivers/media/platform/mediatek/vpu/mtk_vpu.h
> index da05f3e74081..5808311d2b15 100644
> --- a/drivers/media/platform/mediatek/vpu/mtk_vpu.h
> +++ b/drivers/media/platform/mediatek/vpu/mtk_vpu.h
> @@ -120,7 +120,7 @@ int vpu_ipi_send(struct platform_device *pdev,
>   *		device for using VPU API.
>   *
>   * Return: Return NULL if it is failed.
> - * otherwise it is VPU's platform device
> + * otherwise it is VPU's platform device with incremented reference count

I picked this patch but rewrote with what felt like better and dense.

- * Return: Return NULL if it is failed.
- * otherwise it is VPU's platform device
+ * Return: a reference to the VPU's platform device, or NULL on failure.

hope its ok with you,

cheers,
Nicolas

>   **/
>  struct platform_device *vpu_get_plat_device(struct platform_device *pdev);
>  

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)