linux-kernel - Re: [PATCH v2] fjes: Add missing iounmap in fjes_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aTsEJs8oqSS_QjcN@horms.kernel.org>
Date: Thu, 11 Dec 2025 17:49:26 +0000
From: Simon Horman <horms@...nel.org>
To: Haoxiang Li <lihaoxiang@...c.iscas.ac.cn>
Cc: andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, izumi.taku@...fujitsu.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH v2] fjes: Add missing iounmap in fjes_hw_init()

On Thu, Dec 11, 2025 at 03:37:56PM +0800, Haoxiang Li wrote:
> In error paths, add fjes_hw_iounmap() to release the
> resource acquired by fjes_hw_iomap(). Add a goto label
> to do so.
> 
> Fixes: 8cdc3f6c5d22 ("fjes: Hardware initialization routine")
> Cc: stable@...r.kernel.org
> Signed-off-by: Haoxiang Li <lihaoxiang@...c.iscas.ac.cn>
> Signed-off-by: Simon Horman <horms@...nel.org>
> ---
> Changes in v2:
> - Use an idiomatic goto to do the error hanlding.
> - Thanks for pointing out the issues with the patch, Simon!

Likewise thanks for the updates.

Reviewed-by: Simon Horman <horms@...nel.org>