linux-kernel - Re: [RFC PATCH 5/5] firmware: smccc: lfa: refresh fw details

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <44635975-326C-4DD2-BCEC-EB04188E954A@nvidia.com>
Date: Fri, 12 Dec 2025 15:37:00 +0000
From: Matt Ochs <mochs@...dia.com>
To: Vedashree Vidwans <vvidwans@...dia.com>
CC: "salman.nabi@....com" <salman.nabi@....com>, "sudeep.holla@....com"
	<sudeep.holla@....com>, "andre.przywara@....com" <andre.przywara@....com>,
	"lpieralisi@...nel.org" <lpieralisi@...nel.org>, "mark.rutland@....com"
	<mark.rutland@....com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, Varun Wadekar <vwadekar@...dia.com>, Shanker
 Donthineni <sdonthineni@...dia.com>, Vikram Sethi <vsethi@...dia.com>,
	"linux-coco@...ts.linux.dev" <linux-coco@...ts.linux.dev>, "ardb@...nel.org"
	<ardb@...nel.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "chao.gao@...el.com"
	<chao.gao@...el.com>
Subject: Re: [RFC PATCH 5/5] firmware: smccc: lfa: refresh fw details

> On Dec 8, 2025, at 16:13, Vedashree Vidwans <vvidwans@...dia.com> wrote:
> 
> diff --git a/drivers/firmware/smccc/lfa_fw.c b/drivers/firmware/smccc/lfa_fw.c
> index 24916fc53420..334090708405 100644
> --- a/drivers/firmware/smccc/lfa_fw.c
> +++ b/drivers/firmware/smccc/lfa_fw.c
...
> + /*
> + * Pass 2:
> + *    If current FW components number is more than previous list, add new component nodes.
> + */
> + for (node_idx; node_idx < num_of_components; node_idx++) {

drivers/firmware/smccc/lfa_fw.c: In function ‘update_fw_images_tree’:
drivers/firmware/smccc/lfa_fw.c:554:9: warning: statement with no effect [-Wunused-value]
  554 |         for (node_idx; node_idx < num_of_components; node_idx++) {
      |         ^~~

Please drop “node_idx” from the initializer statement.